Conversation
These internal functions were no longer used or defined but the prototype and stub were still present.
If this routine fails then return the error to the caller, which will also prevent the task from starting.
Remove repetitive clearing of the global ID and unlocking global table and replace with common implementation in the idmap code. In addition to removing repeated logic, this makes deletion more like an inverse of creation, and provides a common/single point where additiona deletion-related logic can be added.
Fix #557, remove OS_ObjectIdMap/Unmap prototype and stub
Fix #565, propagate return code from OS_TaskRegister_Impl()
Refactored +dev in OS_VERSION macros
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Aug 25, 2020
Contains: nasa/cFE#833 nasa/osal#576 nasa/to_lab#58 nasa/sch_lab#52 1. Update submodules for IC-20200819 2. Update cfe to reflect HOTFIX nasa/cFE#838 3. Point submodules to main for IC-20200819 Co-authored-by: Yasir Khan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
fix #565
fix #564
fix #557
Testing performed
Bundle CI - https://github.com/nasa/cFS/pull/130/checks
Expected behavior changes
PR #558 - Removes internal functions that are no longer used or defined but whose prototypes and stubs were still present in
OS_ObjectIdMapPR #567 - Removes repetitive clearing of the global ID and unlocking global table and replaces these with common implementation in the idmap source file. This moves deleting tables to be similar to creating tables and provides
a common location for additional table-deletion-related logic.
PR #566 - Propagates return code from
OS_TaskRegister_Impl(). If this routine fails then return the error to the caller, which also prevents the task from starting.System(s) tested on
Ubuntu - CI
Additional context
nasa/cFS#130
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.