Fix #538, correct loop variable for coverage install#539
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Jul 15, 2020
Merged
Conversation
Should use the loop variable (TGT) not TGTNAME.
jphickey
added
the
CCB:Ready
CDKnightNASA
approved these changes
Jul 10, 2020
Contributor
|
CCB-20200715 APPROVED |
astrogeco
removed
the
CCB:Ready
jphickey
added a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix issue regarding inclusion of cfe_platform_cfg.h when multiple CPUs are in use. Also fix for duplicate name collision where different configs exist within the same arch.
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#539, build failure in UT stubs with multiple CPUs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Install use the loop variable (TGT) not TGTNAME for DESTINATION.
Fixes #538
Testing performed
Build with ENABLE_UNIT_TESTS=TRUE and a configuration with multiple CPUs sharing a single arch+platform config.
Expected behavior changes
Without this fix, the coverage binaries are installed twice to CPU2 but not at all for CPU1.
With this fix, they are correctly installed for CPU1 and CPU2.
System(s) tested on
Ubuntu 20.04
Additional context
No change to behavior at all - just an install path fix.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.