Conversation
Added sub functions for: OS_TaskFindIdBySystemData OS_FileSysAddFixedMap OS_TimedRead OS_TimedWrite OS_FileSysAddFixedMap Required for testing other modules that use these functions. Also correct a name mismatch issue in OS_TaskGetInfo.
Correct output value
The buffer for context info increases from 128 to 256 bytes
Fix #485 - add text to make clear that IDs are non-zero
Fix #494, add missing stub functions for OSAL API
Fix #491, increase UT assert buffer sizes
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Integration Candidate 20200212
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #485 - add text to make clear that IDs are non-zero
Fix #494, add missing stub functions for OSAL API
Fix #491, increase UT assert buffer sizes
Testing performed
Bundle CI: https://github.com/nasa/cFS/pull/102/checks
Expected behavior changes
PR #486 - adds "non-zero" to the out variable description for OS_Create (and related) API's.
PR #492 - The buffer for context info increases from 128 to 256 bytes and the total report buffer to 320 bytes.
PR #497 - Added stub functions for
OS_TaskFindIdBySystemData(),OS_FileSysAddFixedMap(),OS_TimedRead(),OS_TimedWrite(), andOS_FileSysAddFixedMap()System(s) tested on
Ubuntu:Bionic
Additional context
Part of nasa/cFS#102
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.
Christopher D. Knight, NASA-ARC