Fix #509, Remove uintmax_t usage#510
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Jun 17, 2020
Merged
Conversation
Some systems may not provide this type. Using "unsigned long" instead should be sufficient.
jphickey
added
the
CCB:Ready
skliper
reviewed
Jun 16, 2020
Contributor
skliper
left a comment
skliper
left a comment
There was a problem hiding this comment.
long long? Is an address ever returned (I'd think it could be).
Contributor
Author
It's in a union with a (FWIW even an old gcc 4.3.3 should definitely provide this type, I didn't dig into it much to see if there was perhaps some other reason it failed, but the regular |
skliper
approved these changes
Jun 17, 2020
Contributor
|
CCB 2020-06-17: APPROVED |
astrogeco
added
IC-20200610
and removed
CCB:Ready
astrogeco
pushed a commit
to nasa/cFS
that referenced
this pull request
Jun 17, 2020
astrogeco
added
the
CCB:Approved
astrogeco
pushed a commit
to nasa/cFS
that referenced
this pull request
Jun 17, 2020
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#509, Executive Services Requirements Scrub
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Some systems may not provide this type. Using
unsigned longinstead should be sufficient.Fixes #509
Testing performed
Build on vxworks
Run all unit tests on native system and on RTEMS.
Expected behavior changes
No impact to behavior
System(s) tested on
Ubuntu 20.04
GSFC VxWorks lab build machine (gs582w-cfelnx)
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.