Fix #502, Add extra assert macros#503
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Jun 17, 2020
Merged
Conversation
Add the following macros for UT assert: UtAssert_INT32_EQ - check equality as 32 bit signed int UtAssert_UINT32_EQ - check equality as 32 bit unsigned int UtAssert_NOT_NULL - check pointer not null UtAssert_NULL - check pointer is null UtAssert_NONZERO - check integer is nonzero UtAssert_ZERO - check integer is zero UtAssert_STUB_COUNT - check stub count These are all just wrappers around UtAssert_True for commonly-used asserts. The description message is auto generated so it is consistent.
jphickey
added
the
CCB:Ready
skliper
approved these changes
Jun 16, 2020
Contributor
|
CCB 2020-06-17: APPROVED and FastTracked |
astrogeco
added
IC-20200610
and removed
CCB:Ready
astrogeco
pushed a commit
to nasa/cFS
that referenced
this pull request
Jun 17, 2020
astrogeco
added
the
CCB:Approved
astrogeco
pushed a commit
to nasa/cFS
that referenced
this pull request
Jun 17, 2020
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#503, better events for CFE_TBL_Load()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Add the following macros for UT assert:
UtAssert_INT32_EQ- check equality as 32 bit signed intUtAssert_UINT32_EQ- check equality as 32 bit unsigned intUtAssert_NOT_NULL- check pointer not nullUtAssert_NULL- check pointer is nullUtAssert_NONZERO- check integer is nonzeroUtAssert_ZERO- check integer is zeroUtAssert_STUB_COUNT- check stub countThese are all just wrappers around
UtAssert_Truefor commonly-used asserts. The description message is auto generated so it is consistent.Fixes #502
Testing performed
Build and run all existing unit tests.
Also test with new PSP coverage tests that use the new macros and confirm they work as described.
Expected behavior changes
No impact to current behavior. These are just new macros for new test case, to improve ease of use and consistency for future testing.
System(s) tested on
Ubuntu 20.04
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.