Fix #494, add missing stub functions for OSAL API#497
Merged
astrogeco merged 2 commits intonasa:integration-candidatefrom Jun 17, 2020
Merged
Fix #494, add missing stub functions for OSAL API#497astrogeco merged 2 commits intonasa:integration-candidatefrom
astrogeco merged 2 commits intonasa:integration-candidatefrom
Conversation
Added sub functions for: OS_TaskFindIdBySystemData OS_FileSysAddFixedMap OS_TimedRead OS_TimedWrite OS_FileSysAddFixedMap Required for testing other modules that use these functions. Also correct a name mismatch issue in OS_TaskGetInfo.
Correct output value
Contributor
Author
|
Note - commit b6b1ad8 corrects a copy/paste issue with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Did a quick scrub for public OSAL APIs defined in
libosal.abut not defined in stub library.Added stub functions for:
Required for testing other modules that use these functions. Also correct a name mismatch issue in
OS_TaskGetInfo().Fixes #494
Testing performed
Build and run all unit tests.
Expected behavior changes
No change to behavior or FSW. Just adds stubs for future use.
System(s) tested on
Ubuntu 20.04
Additional context
These were not actively used anywhere yet (otherwise would be a link failure) but likely to become an issue as PSP coverage tests are implemented.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.