Skip to content

Fix #379, Add FileSysAddFixedMap functional API test#489

Merged
astrogeco merged 3 commits intonasa:integration-candidatefrom
yammajamma:fix379-2-Add-FileSysAddFixedMap-Functional-API-Test
Aug 14, 2020
Merged

Fix #379, Add FileSysAddFixedMap functional API test#489
astrogeco merged 3 commits intonasa:integration-candidatefrom
yammajamma:fix379-2-Add-FileSysAddFixedMap-Functional-API-Test

Conversation

@yammajamma
Copy link
Contributor

Fix #379, Add FileSysAddFixedMap functional API test.

Describe the contribution
Added FileSysAddFixedMap functional API test

Testing performed
Steps taken to test the contribution:

  1. Standard build and ran unit tests.

System(s) tested on
cFS Dev Server
OS: Ubuntu 18.04
Versions: OSAL 5.0.11.0

Contributor Info - All information REQUIRED for consideration of pull request
Yasir Majeed Khan
NASA GSFC/Emergent Space

@yammajamma
Copy link
Contributor Author

@skliper would you mind reviewing this when you get a chance? Thanks!

@astrogeco
Copy link
Contributor

@yammajamma is this ready?

@yammajamma
Copy link
Contributor Author

@astrogeco it is, but it hasn't been reviewed by @skliper yet

@astrogeco astrogeco requested a review from skliper June 17, 2020 15:06
@astrogeco
Copy link
Contributor

@astrogeco it is, but it hasn't been reviewed by @skliper yet

We can bring it up at the CCB and get some more eyes on it then

@astrogeco astrogeco added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Jun 17, 2020
@astrogeco astrogeco marked this pull request as draft June 22, 2020 19:40
@astrogeco astrogeco removed the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Jun 22, 2020
@astrogeco
Copy link
Contributor

Converted to Draft until ready for review

@skliper
Copy link
Contributor

skliper commented Jul 27, 2020

@yammajamma - could you update the status on this one?

@yammajamma
Copy link
Contributor Author

yammajamma commented Aug 3, 2020 via email

@yammajamma yammajamma force-pushed the fix379-2-Add-FileSysAddFixedMap-Functional-API-Test branch from 54bc184 to c26479d Compare August 10, 2020 14:50
@yammajamma yammajamma added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Aug 11, 2020
@yammajamma yammajamma marked this pull request as ready for review August 11, 2020 15:25
@skliper
Copy link
Contributor

skliper commented Aug 12, 2020

CCB 2020-08-12: Approved

@astrogeco astrogeco added CCB-20200812 CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Aug 14, 2020
@astrogeco astrogeco changed the base branch from master to main August 14, 2020 00:05
@astrogeco astrogeco changed the base branch from main to integration-candidate August 14, 2020 00:06
@astrogeco astrogeco marked this pull request as draft August 14, 2020 00:06
@astrogeco astrogeco marked this pull request as ready for review August 14, 2020 00:06
@astrogeco astrogeco dismissed skliper’s stale review August 14, 2020 00:07

Comments resolved

@astrogeco astrogeco merged commit 34e0978 into nasa:integration-candidate Aug 14, 2020
@skliper skliper added this to the 5.1.0 milestone Aug 21, 2020
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
Fix nasa#489, Add usersguide/osalguide to local targets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CCB:Approved Indicates code review and approval by community CCB

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OS_FileSysAddFixedMap missing functional test

4 participants