Fix #293, Expand API for object queries#469
Merged
astrogeco merged 2 commits intonasa:integration-candidatefrom May 26, 2020
Merged
Fix #293, Expand API for object queries#469astrogeco merged 2 commits intonasa:integration-candidatefrom
astrogeco merged 2 commits intonasa:integration-candidatefrom
Conversation
Integration Candidate COMBINED 2020-04-29 and 2020-05-06
Implement OS_GetResourceName, OS_ForEachObjectByType
astrogeco
added
the
CCB:Ready
Contributor
|
CCB 20200520 - APPROVED |
skliper
removed
the
CCB:Ready
Closed
Closed
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Added tests to complete coverage on the following functions: * CFE_ES_RunAppTableScan * CFE_ES_ParseFileEntry * CFE_ES_LoadModule * CFE_ES_CleanUpApp * CFE_ES_CleanupObjectCallback
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#469, Adding coverage tests for cfe_es_apps.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Implement
OS_GetResourceName()andOS_ForEachObjectOfType(), which are new functions that allow for additional query capabilities.OS_ObjectIdToArrayIndex()modified to acceptOS_OBJECT_TYPE_UNDEFINEDas the first parameter, to allow it to work with any object type, not just objects for which a specific type is expected/known.Also adds unit test (functional + coverage) for
OS_ForEachObjectByTypeandOS_GetResourceNameFixes #293
Testing performed
Run all unit tests, sanity check CFE and confirm normal operation
Expected behavior changes
No impact to current behavior as the FSW does not currently use any of these new APIs. Existing APIs are unchanged.
System(s) tested on
Ubuntu 20.04
Additional context
Querying objects by type is potentially needed for nasa/cFE#701 and nasa/FM#2
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.