Fix #449, Rename BSPs to be generic#467
Merged
astrogeco merged 3 commits intonasa:integration-candidatefrom Jun 2, 2020
Merged
Fix #449, Rename BSPs to be generic#467astrogeco merged 3 commits intonasa:integration-candidatefrom
astrogeco merged 3 commits intonasa:integration-candidatefrom
Conversation
Contributor
Author
|
Created as a draft due to baseline issues. Only commit for review here is b8cd3d4. |
Closed
jphickey
force-pushed
the
fix-449-generic-bsps
branch
from
b8cd3d4 to
8386f6f
Compare
skliper
approved these changes
May 16, 2020
Contributor
|
CCB 20200520 - APPROVED, needs to be merged on top of related PRs. Paired with PSP fixes |
Integration Candidate 2020-05-13
astrogeco
added
the
CCB:Approved
Contributor
|
@jphickey can I merge this? |
Contributor
Author
|
Lets hold off to next cycle, I prefer to rebase to "master" to fix this. |
Integration Candidate 2020-05-20
These adaptor layers can be used on a variety of boards. Renaming the directory reflects that. Note - not renaming pc-rtems at this time, as that still has some non-generic aspects to it.
jphickey
force-pushed
the
fix-449-generic-bsps
branch
from
8386f6f to
11a4899
Compare
Contributor
Author
|
Rebased to current master, should be good to go now. |
Contributor
|
@astrogeco This is a project priority, Can it move forward? |
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Completed 100% coverage on cfe_es_start.c
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#467, #1636 Complete coverage for cfe_es_start.c and cfe_es_syslog.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Rename BSPs that can be used on multiple platforms.
mcp750-vxworks becomes generic-vxworks
pc-linux becomes generic-linux
(pc-rtems stays the same for now)
Testing performed
Build for all supported operating systems (linux, vxworks, rtems) and confirm all unit tests pass and CFE runs normally.
Expected behavior changes
No impact to behavior, but build scripts in external entities need to change the name.
System(s) tested on
Ubuntu 20.04 (native)
RTEMS 4.11 on pc686 / QEMU
VxWorks 6.9 on MCP750
Additional context
See related issue nasa/PSP#162 and PR nasa/PSP#164 which changes the refs to these.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.