Fix #367, 453, 456, 460, Deprecate OS_VolumeTable and other fixes#461
Merged
astrogeco merged 4 commits intonasa:integration-candidatefrom May 28, 2020
Merged
Conversation
Remove the OS_VolumeTable definition from all BSPs, but provide a default (empty) one to support linking when OMIT_DEPRECATED is not set.
Do not assume BSP volume table provides a "/cf" directory map. Instead, create a UT-specific map of a consistent name, and use that.
jphickey
force-pushed
the
fix-367-deprecate-voltab
branch
from
acdf156 to
91b3921
Compare
This was
linked to
issues
May 15, 2020
jphickey
changed the title
This was referenced May 15, 2020
jphickey
force-pushed
the
fix-367-deprecate-voltab
branch
from
91b3921 to
aade493
Compare
Add a distinct type for FS_BASED entries, and an UNKNOWN value for when a type is actually not yet identified. This can be used to identify the FS type first at the shared layer, then in the implementation layer as a fallback option if not identifiable in the shared layer. Use the volume name prefix "RAM" as a hint that the volume is supposed to be a VOLATILE disk as opposed to a normal disk. This is done in shared layer so it applies to all OS types.
Confirm that the "selectable" flag is set before calling the underlying select() API. Also update unit tests to match.
jphickey
force-pushed
the
fix-367-deprecate-voltab
branch
from
aade493 to
312b7cc
Compare
jphickey
added
the
CCB:Ready
skliper
approved these changes
May 18, 2020
Contributor
|
CCB 20200520 - APPROVED |
skliper
added
CCB-20200520
and removed
CCB:Ready
astrogeco
added
CCB:Approved
Contributor
|
@acudmore did you take a look at this? |
Contributor
Author
|
Note - Lack of this PR is causing the current IC to fail as it is correlated with nasa/PSP#163. We either need to merge this or, if this cannot be merged in this cycle, we need to revert the PSP change. |
Contributor
I merged the psp one in anticipation that @acudmore would review this one soonish. I think he's working on it today. |
ghost
approved these changes
May 28, 2020
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Approve. Getting rid of the volume table is another improvement.
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#315, ES Performance debug messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Deprecate the OS_VolumeTable structure, which is no longer necessary with the current OSAL.
Remove the OS_VolumeTable definition from all BSPs, and provide a default (empty) one to support linking when OMIT_DEPRECATED is not set.
Note Due to unit test dependencies this PR also has to include fixes for other related issues.
Fix #367
Fix #453
Fix #456
Fix #460
These are all in separate commits and they each build individually but there are some dependencies in making the unit tests work, so they were added to this PR.
Testing performed
Build with unit tests, confirm unit test execution and sanity check CFE on supported platforms
Expected behavior changes
OSAL no longer defines the types or symbols associated with OS_VolumeTable when OMIT_DEPRECATED is set. Any external PSPs should replace their respective OS_VolumeTable with calls to the runtime registration API.
System(s) tested on
Ubuntu 20.04 (native)
RTEMS 4.11 on i686 via QEMU
Vxworks 6.9 on MCP750
Additional context
nasa/PSP#161 exists to remove these references from the CFE PSP
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.