Fix #435, fix string manipulations to avoid warnings#441
Merged
astrogeco merged 2 commits intonasa:integration-candidatefrom May 11, 2020
Merged
Fix #435, fix string manipulations to avoid warnings#441astrogeco merged 2 commits intonasa:integration-candidatefrom
astrogeco merged 2 commits intonasa:integration-candidatefrom
Conversation
jphickey
force-pushed
the
fix-435-string-ops
branch
from
adca7b5 to
7a948b8
Compare
Resize buffers and tweak string copies to avoid truncation warnings in GCC 9. Note the code was generally OK (handled truncation) but the new compiler still generates warnings even with correct usage of certain functions. In the UT_os_printf macro, be sure to "use" the return value of the snprintf() call, which avoids warnings about truncation.
jphickey
force-pushed
the
fix-435-string-ops
branch
from
7a948b8 to
a227f3b
Compare
jphickey
added
the
CCB:Ready
Contributor
Author
|
This is now rebased to "master" and its good to go. |
Contributor
|
CCB 20200506 - Will revisit to touch up, concept approved |
astrogeco
added
CCB-20200506
and removed
CCB:Ready
astrogeco
added
CCB:Approved
Contributor
|
@jphickey I remember there was an extra fix you wanted to add to this but I don't recall the specifics... |
skliper
reviewed
May 8, 2020
skliper
approved these changes
May 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Resize buffers and add explicit termination to string copies.
Avoids warnings on GCC9 with strict settings and optimization enabled.
Fixes #435
Testing performed
Build with default config and gcc 9.3.0 and confirm warnings are gone
Expected behavior changes
Warnings fixed.
System(s) tested on
Ubuntu 20.04 LTS
Additional context
Currently a draft because it uses PR #427 as a baseline. Will mark as non-draft once prerequisite is merged.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey Vantage Systems, Inc.