Merged
Conversation
…n-Fix Fix #425, Correct Test_OS_ConvertToArrayIndex assertion typo
Fix #346, Adds library build, functional, and coverage test to CI
Fix #424, Add looping wait for self exiting task
unit-tests/osloader-test: make modules always be built for the test
Changes FileName in os_dirent_t from OS_MAX_PATH_LEN to OS_MAX_FILE_NAME, and moves OS_check_name_length into OS_TranslatePath so it is consistantly applied everywhere. Also fixes the length checks in OS_check_name_length to account for terminating null. Unit tests updated to match new directory name limit. Coverage tests updated to match simplified logic.
Fix #344, Consistent directory entry size limit
astrogeco
force-pushed
the
integration-candidate
branch
from
908709a to
7a7e6d1
Compare
Contributor
Contributor
|
Not sure why that commit was cherry-picked .... this integration is still wrong in many ways. There are still a lot of conflicts with the OS_FS_* error code changes and the file restructures to handle the shell, etc etc. There is a lot broken in the current IC. The original rebase of #285 (in IC commit 1431232) is simply incorrect. The commit 101862e has all of this stuff fixed - I already worked out all of these issues. |
Contributor
astrogeco
force-pushed
the
integration-candidate
branch
from
fffaad4 to
a67ad31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Integration Candidate 2020-04-22
Fixes: #262, #344, #424, #346, #430, and #425
Testing performed
CI - https://github.com/nasa/osal/pull/440/checks?check_run_id=633931133
Bundle CI- https://github.com/nasa/cFS/pull/74/checks?check_run_id=637311464
See PRs for other tests
Expected behavior changes
OS_FS_SUCCESS, OS_FS_ERROR , OS_FS_ERR_INVALID_POINTER, OS_FS_ERR_NO_FREE_FDS , OS_FS_ERR_INVALID_FD, and OS_FS_UNIMPLEMENTEDfrom from osapi-os-filesys.hOS_MAX_FILE_NAMElocal_idx1is now compared withlocal_idx2osal_loader_UTtest is built and runSystem(s) tested on
CI - Ubuntu:Bionic
Additional context
Part of nasa/cFS#74
Third party code
If included, identify any third party code and provide text file of license
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman, NASA-GSFC
Dan Knutsen, NASA/Goddard
Yasir Khan, NASA-GSFC
Stanislav Pankevich, PTS GmbH