Fix #430, unit-tests/osloader-test: make modules always be built for the test#431
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Apr 28, 2020
Merged
Conversation
skliper
added
the
CCB:Ready
14 tasks
Contributor
|
20200422 - CCB conditionally approved, will test |
skliper
added
CCB - 20200422
CCB:Approved
Contributor
|
@skliper I prematurely merged this into the integration candidate, what are the tests you wanted to do? |
Contributor
|
@astrogeco it's fine to merge into IC. @jphickey just wanted to test/review closely. |
astrogeco
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fixes #430.
Testing performed
Running
osal_loader_UTon macOS as described in the linked issue.Expected behavior changes
Without this patch, the MODULE* files are not generated in the build folder.
After this patch is applied, the module files are generated when the
osal_loader_UTtest is built and run:System(s) tested on
Additional context
None.
Third party code
None.
Contributor Info - All information REQUIRED for consideration of pull request
Stanislav Pankevich, PTS GmbH
The hand signed CLA has been sent before.