Fix #424, Add looping wait for self exiting task#426
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Apr 28, 2020
Merged
Fix #424, Add looping wait for self exiting task#426astrogeco merged 1 commit intonasa:integration-candidatefrom
astrogeco merged 1 commit intonasa:integration-candidatefrom
Conversation
skliper
added
the
CCB:Ready
Contributor
Author
|
@stanislaw @yammajamma - could you test on your systems that reported failure? If you run with debug |
Contributor
Author
|
Or pipe to a file so you can see the exit status... whatever. |
Contributor
|
CCB 20200422 - Add upper limit to loop, APPROVED |
skliper
added
CCB - 20200422
CCB:Approved
skliper
force-pushed
the
fix424-self-exit-task-delay
branch
from
5a09605 to
e7bba8f
Compare
Contributor
Author
|
Added loop limit of 100, and assert |
Contributor
Author
|
Tested with bundle, SIMULATION=native ENABLE_UNIT_TEST=true. Passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Loops the parent OS_TaskDelay until child task exits before testing OS_TaskDelete. Avoids the test depending on system loading/performance with single delay approach.
Fix #424
Testing performed
Steps taken to test the contribution:
osal-core-test -dand observed Loop count of 1 (I've never experienced the failure, which if avoided would have a loop count > 1)Expected behavior changes
Consistent osal-core-test execution status
System(s) tested on
Additional context
Issue seen on dev server 4 and Mac OS
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC