Fix #354, Shell related API separated for optional implementation#418
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Apr 22, 2020
Merged
Conversation
skliper
added
the
CCB:Ready
Contributor
Contributor
Author
|
CCB 20200415 - APPROVED, will need rebase prior to merge to IC |
Defaults to not include OS_ShellOutputToFile implementation
skliper
force-pushed
the
fix354-shell-split
branch
from
3fd78d7 to
1f5bdcb
Compare
Contributor
Author
|
Rebased on master |
astrogeco
added
CCB:Approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Adds a portable OS_ShellOutputToFile_Impl no-shell implementation following the no-network model
Splits posix/rtems/vxworks OS_ShellOutputToFile_Impl into a separate osshell.c (was in osfileapi.c)
Defaults to use the not implemented version (to match certification target)
Added unit test wrapper
Fix #354
Testing performed
Steps taken to test the contribution:
NOTE - build for vxworks attempted, but ran into other issues introduced since last check on that system (elf2cfetbl casts missing to match format)
Expected behavior changes
Command to run in shell and output to fill will fail with default (not implemented) setting. Open issue to resolve is nasa/cFE#484
System(s) tested on
Hardware: cFS Dev Server
OS: Ubuntu 18.04
Versions: Master bundle w/ this commit on top of Fix #581, Propagate the OSAL compile definitions to CFE build cFE#585, Fix #121, Unify CFE PSP with OSAL BSP PSP#149, Fix #261, #312, and #362, OSAL build cleanup (multiple issues) #404
Recommend build/test on RTEMS
Resolve unrelated issue for VxWorks and complete test
Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC