Fix #232, pthread stack min typo#402
Merged
astrogeco merged 2 commits intonasa:integration-candidatefrom Apr 15, 2020
Merged
Conversation
skliper
approved these changes
Apr 2, 2020
skliper
added
enhancement
CCB:Ready
astrogeco
changed the title
Contributor
|
CCB 20200408 - APPROVED |
astrogeco
added
CCB - 20200408
CCB:Approved
Contributor
|
@skliper do we have a CLA for this? |
Contributor
|
@astrogeco Yes, CLA receipt confirmed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fixes #232 PTHREAD_STACK_MIN typo. I could have changed the number to 8192 but I thought (8*1024) was more true to where the number comes from. Let me know if this is not inline with NASA code style preferences.
Testing performed
Steps taken to test the contribution:
cmake -DOSAL_SYSTEM_OSTYPE=posix -DOSAL_SYSTEM_BSPTYPE=pc-linux -DENABLE_UNIT_TESTS=TRUE -DOSAL_INCLUDEDIR=/home/david/projects/config -DCFE_SYSTEM_PSPNAME=whyohwhy /home/david/projects/osalNote that osloader module test nominal 7 failed (ut_osloader_module_test.c:242) but it failed no matter whether my changes were implemented or not. I assume it's a quirk of my system/environment.
Expected behavior changes
System(s) tested on
Additional context
N/A
Third party code
N/A
Contributor Info - All information REQUIRED for consideration of pull request
David Archuleta Jr.
Personal