Fix #88, Add test for name too long and update comments #398
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Apr 21, 2020
Merged
Fix #88, Add test for name too long and update comments #398astrogeco merged 1 commit intonasa:integration-candidatefrom
astrogeco merged 1 commit intonasa:integration-candidatefrom
Conversation
Contributor
|
Nitpick - could you update the commit message to stand alone? Something like: |
Contributor
|
Oh, and the issue description needs to explicitly say: This autolinks the pull request it with the issue. |
dmknutsen
changed the title
skliper
approved these changes
Apr 9, 2020
skliper
added
the
CCB:Ready
skliper
suggested changes
Apr 10, 2020
skliper
approved these changes
Apr 13, 2020
astrogeco
changed the title
Contributor
|
CCB 20200415 - APPROVED |
Contributor
|
Can we add a similar comment to OS_MAX_FILE_NAME or is it too late? |
Contributor
|
@dmknutsen @astrogeco actually, I can do the change in my commit... retracting previous comment. |
astrogeco
added
CCB:Approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fixes #88, Add test for name too long and update comments.
Coverage test added to OS_TimerCreate for OS_ERR_NAME_TOO_LONG.
Updated comments related to sizing includes null terminator for:
OS_MAX_API_NAME, OS_MAX_PATH_LEN, OS_BUFFER_SIZE
Testing performed
Ran unit tests.
System(s) tested on
Oracle VM VirtualBox
OS: ubuntu-19.10
Versions: cFE 6.7.11.0, OSAL 5.0.9.0, PSP 1.4.7.0
Contributor Info
Dan Knutsen
NASA/Goddard