Conversation
Contributor
Author
|
CCB 20200122 - Reviewed and approved for merge to master |
skliper
added
the
CCB:Approved
jphickey
added a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Adds a "global_build_options.cmake" file akin to the existing arch_build/mission_build option files. Include an example of this file that optionally does add_definitions() to omit the deprected elements for build testing.
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#355, Add global scope option to omit deprecated items
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #328, fix #329
Testing performed
Steps taken to test the contribution:
Expected behavior changes
Resolved LGTM errors, no functional changes
System(s) tested on
Additional context
N/A
Third party code
N/A
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC