fix #328, lgtm warning#330
Merged
skliper merged 1 commit intonasa:ic-20200121from Jan 21, 2020
avan989:new_lgtm_warning
Merged
Conversation
skliper
suggested changes
Dec 30, 2019
Contributor
skliper
left a comment
skliper
left a comment
There was a problem hiding this comment.
Remove break; after return since it is unreachable code. Multiple instances.
Contributor
Author
|
updated. |
jphickey
requested changes
Jan 8, 2020
Contributor
jphickey
left a comment
jphickey
left a comment
There was a problem hiding this comment.
Changes noted in previous review comments
Contributor
Author
|
updated. Split os-impl-bsd-sockets.c to a separate issue. |
skliper
approved these changes
Jan 14, 2020
jphickey
approved these changes
Jan 14, 2020
skliper
added
the
CCB:Approved
Contributor
|
CCB 20200115 - Reviewed and approved for IC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
fix lgtm warning.
Testing performed
Steps taken to test the contribution:
System(s) tested on:
Contributor Info
Anh Van, NASA Goddard.