Refactor OSAL C library stubs#319
Merged
skliper merged 2 commits intonasa:ic-20191230from Dec 31, 2019
Merged
Conversation
Rather than utilizing a separate "stub-map-to-real.h" file that would need to be injected into the build of the unit under test, this builds the mappings into the mapping into the override files themselves. The stub functions are then moved into a separate header under a unique name with an OCS_ prefix. This introduces a number of new files, as what previously required a single header now requires two, but it it eliminates the separate map file.
skliper
suggested changes
Dec 17, 2019
Contributor
skliper
left a comment
skliper
left a comment
There was a problem hiding this comment.
Needs copyright header in all the headers?
skliper
added
the
CCB:Approved
Contributor
|
CCB 20191218 - Reviewed and approved for IC |
Contributor
|
Merge pending copyright header in new files. |
Adds a NOSA copyright header to all files touched as part of the fix for nasa#297.
skliper
approved these changes
Dec 31, 2019
skliper
added a commit
that referenced
this pull request
Dec 31, 2019
Fix #297 Reviewed and approved at 2019-12-18 CCB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #297
Rather than utilizing a separate "stub-map-to-real.h" file that would need to be injected into the build of the unit under test, this builds the mappings into the mapping into the override files themselves.
The stub functions are then moved into a separate header under a unique name with an OCS_ prefix.
This introduces a number of new files, as what previously required a single header now requires two, but it it eliminates the separate map file.
Testing performed
Build coverage test before and after change, confirm no changes to test operation or result.
Expected behavior changes
None, just a structural change to the source file layout/patterns
System(s) tested on:
Contributor Info
Joseph Hickey, Vantage Systems, Inc.
Community contributors
You must attach a signed CLA (required for acceptance) or reference one already submitted