Fix minor warnings in OSAL code#299
Merged
skliper merged 2 commits intonasa:merge-20191230from Dec 30, 2019
Merged
Conversation
Fix warnings that are triggered by compiling the OSAL coverage unit test with strict settings. - The OS_FPUExcAttachHandler function needs to be prototyped as accepting a function pointer (not void*) - Const-Correctness on OS_ModuleLoad_Impl() - Use void* instead of char* for buffer pointer as the specific type is not known - Cast the function passed into taskSpawn on VxWorks
jphickey
force-pushed
the
fix-298-strict-warnings
branch
from
3110d25 to
2d27496
Compare
Additional compiler warning fixes for the UT code itself. This is committed separately from the changes that affect the OSAL FSW code.
skliper
approved these changes
Dec 10, 2019
skliper
approved these changes
Dec 10, 2019
skliper
added
the
CCB:Approved
zanzaben
added a commit
to zanzaben/osal
that referenced
this pull request
Jan 4, 2021
zanzaben
added a commit
to zanzaben/osal
that referenced
this pull request
Jan 6, 2021
zanzaben
added a commit
to zanzaben/osal
that referenced
this pull request
Jan 13, 2021
zanzaben
added a commit
to zanzaben/osal
that referenced
this pull request
Jan 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #298
Fix warnings that are triggered by compiling the OSAL coverage unit test with strict settings.
OS_FPUExcAttachHandler()function needs to be prototyped as accepting a function pointer (notvoid*)OS_ModuleLoad_Impl()void*instead ofchar*for buffer pointer as the specific type is not knowntaskSpawn()on VxWorksTesting performed
Build code on all three supported OS's (POSIX, RTEMS, VxWorks) with full warnings and ENABLE_UNIT_TESTS=TRUE
Execute all unit tests and confirm passage
Execute cFE and confirm normal operation
Expected behavior changes
None.
System(s) tested on:
Contributor Info
Joseph Hickey, Vantage Systems, Inc.
Community contributors
You must attach a signed CLA (required for acceptance) or reference one already submitted