Conversation
Replace use of (1<<31) and (INT_MAX) with (UINT32_MAX/2) which should squelch the cppcheck warnings about the left shift as well as being more correct (the values in question are uint32's, not int's). Also address two false positives about a return value being unassigned, by simply initializing the value to be 0.
Fixes #287: cppcheck warnings
jphickey
approved these changes
Nov 20, 2019
Contributor
jphickey
left a comment
jphickey
left a comment
There was a problem hiding this comment.
Sanity-checked as part of CFS bundle on Ubuntu 18.04 64-bit and Raspberry Pi (Raspbian 32-bit). Confirmed successful build and execution of CFE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fixes #280, fixes #286, fixes #287
Testing performed
Steps taken to test the contribution:
Built without warnings, all tests passed except osal_timer_UT (nominal result on linux)
executed cfe, successful startup with no warnings
Confirmed passed CI (with cppcheck enforced!)
Expected behavior changes
No functional changes, all doxygen/cppcheck warning/error cleanup
System(s) tested on:
Additional context
None
Contributor Info
Jacob Hageman - NASA/GSFC