Fix #286, fix cppcheck warning for unit-test#288
Merged
skliper merged 1 commit intonasa:merge-20191115from Nov 15, 2019
avan989:cppcheck
Merged
Fix #286, fix cppcheck warning for unit-test#288skliper merged 1 commit intonasa:merge-20191115from avan989:cppcheck
skliper merged 1 commit intonasa:merge-20191115from
avan989:cppcheck
Conversation
skliper
reviewed
Nov 12, 2019
Contributor
skliper
left a comment
skliper
left a comment
There was a problem hiding this comment.
Suggest for ut_osprintf_offset.c, just move va_end calls after the UT_CheckArgumentOffset call.
Contributor
Author
|
updated. |
skliper
approved these changes
Nov 13, 2019
Contributor
|
CCB 20191123 - approved for integration candidate |
skliper
added
the
CCB:Approved
skliper
pushed a commit
that referenced
this pull request
Nov 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Resolve cppcheck warning for unit-tests.
Did not compiled unit test.
Testing performed
Steps taken to test the contribution:
System(s) tested on:
Contributor Info
Anh Van, NASA Goddard
Community contributors
You must attach a signed CLA (required for acceptance) or reference one already submitted