Conversation
Qualify all pointers referring to string literals as `const` Eliminate unused local variables Add missing local function prototypes.
Update all block comments for OSAL functions to follow a consistent style and ensure correctness of the descriptions. - All documentation covering the specific details, inputs/outputs and return values should be on the function _declaration_, not the definition. - The definition should also contain a block comment for visual distinction in the source file, but should be brief and refer back to the prototype/declaration for detail. Any detail information that was indicated only with the definition is moved to the declaration. - Add doxygen tags/markup to external/public API block comments and expand the descriptions of these functions where needed. - Add block comments to the internal API prototypes, but _not_ as doxygen tags/markup. Note these functions are internal use, not part of the public API, and are not necessarily intended to be stable across OSAL releases like the public API is. - Removed stray prototypes for functions where there was no actual definition/implementation.
skliper
added
the
CCB:Approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Covers the following pull requests:
Testing performed
Steps taken to test the contribution:
Expected behavior changes
Only functional change is OS_TimerSet returns OS_ERROR on 0,0, see pull requests for full details
System(s) tested on:
Additional context
NA
Contributor Info
Jacob Hageman - NASA/GSFC
Community contributors
CLA on file