Skip to content

Comments

Fix #1432 #1411, RTEMS semaphore return bugs and functional test update#1438

Merged
dzbaker merged 2 commits intonasa:mainfrom
skliper:fix1432-rtems_semaphore_returns
Jan 10, 2024
Merged

Fix #1432 #1411, RTEMS semaphore return bugs and functional test update#1438
dzbaker merged 2 commits intonasa:mainfrom
skliper:fix1432-rtems_semaphore_returns

Conversation

@skliper
Copy link
Contributor

@skliper skliper commented Dec 29, 2023

Checklist (Please check before submitting)

Describe the contribution

Testing performed
Ran the updated functional tests on pclinux and leon3/RTEMS 5, passed

Expected behavior changes
Semaphore returns now match expected behavior (see #1432)

System(s) tested on

  • Hardware: docker/leon3
  • OS: Ubuntu 22.04, RTEMS 5
  • Versions: Main + this commit

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request

  • Jacob Hageman NASA/GSFC

Ping @pepepr08

@skliper skliper added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Dec 29, 2023
@skliper skliper force-pushed the fix1432-rtems_semaphore_returns branch from 4a51d37 to 46c65e6 Compare December 29, 2023 21:13
@skliper skliper changed the title Fix #1432, RTEMS semaphore return bugs and functional test update Fix #1432 #1411, RTEMS semaphore return bugs and functional test update Dec 29, 2023
@skliper
Copy link
Contributor Author

skliper commented Dec 29, 2023

Format check fails on commit message due to solving multiple issues (check too restrictive)

@dzbaker dzbaker added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Jan 4, 2024
dzbaker added a commit that referenced this pull request Jan 5, 2024
Fix #1432 #1411, RTEMS semaphore return bugs and functional test update
dzbaker added a commit to nasa/cFS that referenced this pull request Jan 5, 2024
*Combines:*

sch_lab v2.5.0-rc4+dev83
osal v6.0.0-rc4+dev251
PSP v1.6.0-rc4+dev115

**Includes:**

*cFS*
- #725

*sch_lab*
- nasa/sch_lab#164
- nasa/sch_lab#163

*osal*
- nasa/osal#1438

*PSP*
- nasa/PSP#380

Co-authored by: Joseph Hickey <[email protected]>
Co-authored by: Avi Weiss <[email protected]>
Co-authored by: Jacob Hageman <[email protected]>
@dzbaker dzbaker mentioned this pull request Jan 5, 2024
2 tasks
dzbaker added a commit to nasa/cFS that referenced this pull request Jan 8, 2024
*Combines:*

sch_lab v2.5.0-rc4+dev83
osal v6.0.0-rc4+dev251
PSP v1.6.0-rc4+dev115

**Includes:**

*cFS*
- #725

*sch_lab*
- nasa/sch_lab#164
- nasa/sch_lab#163

*osal*
- nasa/osal#1438

*PSP*
- nasa/PSP#380

Co-authored by: Joseph Hickey <[email protected]>
Co-authored by: Avi Weiss <[email protected]>
Co-authored by: Jacob Hageman <[email protected]>
@skliper skliper force-pushed the fix1432-rtems_semaphore_returns branch from 1ebcf42 to 0f54ccc Compare January 10, 2024 17:33
dzbaker added a commit to nasa/cFS that referenced this pull request Jan 10, 2024
*Combines:*

sch_lab v2.5.0-rc4+dev83
osal v6.0.0-rc4+dev251
PSP v1.6.0-rc4+dev115

**Includes:**

*cFS*
- #725

*sch_lab*
- nasa/sch_lab#164
- nasa/sch_lab#163

*osal*
- nasa/osal#1438

*PSP*
- nasa/PSP#380

Co-authored by: Joseph Hickey <[email protected]>
Co-authored by: Avi Weiss <[email protected]>
Co-authored by: Jacob Hageman <[email protected]>
@dzbaker dzbaker merged commit 270e099 into nasa:main Jan 10, 2024
dzbaker added a commit to nasa/cFS that referenced this pull request Jan 10, 2024
*Combines:*

sch_lab v2.5.0-rc4+dev83
osal v6.0.0-rc4+dev251
PSP v1.6.0-rc4+dev115

**Includes:**

*cFS*
- #725

*sch_lab*
- nasa/sch_lab#164
- nasa/sch_lab#163

*osal*
- nasa/osal#1438

*PSP*
- nasa/PSP#380

Co-authored by: Joseph Hickey <[email protected]>
Co-authored by: Avi Weiss <[email protected]>
Co-authored by: Jacob Hageman <[email protected]>
@skliper skliper deleted the fix1432-rtems_semaphore_returns branch April 1, 2024 15:14
@dzbaker dzbaker added this to the v7.0.0 milestone Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CCB:Approved Indicates code review and approval by community CCB

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RTEMS OS_BinSemTimedWait_Impl and OS_CountSemTimedWait_Impl return incorrect status Add functional test for sem takes with 0 timeout

2 participants