Fix #1412, Wrong memory alignment calculation#1413
Merged
Conversation
jphickey
reviewed
Nov 13, 2023
Contributor
jphickey
left a comment
jphickey
left a comment
There was a problem hiding this comment.
Thanks for submitting this, I don't know how this had been in there for years and never noticed.
jphickey
force-pushed
the
fix-1412-wrong-memory-alignment
branch
from
7e1ffbb to
51ec0e4
Compare
jphickey
approved these changes
Nov 13, 2023
Contributor
jphickey
left a comment
jphickey
left a comment
There was a problem hiding this comment.
I just reverted the change from cpuaddr back to size_t -- as the NextSize local variable is a size_t here. Pedantic as they are almost certainly the same underlying type, but correct nonetheless. Just need the "-1".
This was referenced Nov 13, 2023
dzbaker
added
the
CCB:Approved
2 tasks
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Dec 5, 2023
*Combines:* to_lab v2.5.0-rc4+dev71 ci_lab v2.5.0-rc4+dev77 cFE v7.0.0-rc4+dev427 PSP v1.6.0-rc4+dev102 osal v6.0.0-rc4+dev243 **Includes:** *to_lab* - nasa/to_lab#173 *ci_lab* - nasa/ci_lab#157 - nasa/ci_lab#159 - nasa/ci_lab#161 *cFE* - nasa/cFE#2411 - nasa/cFE#2409 - nasa/cFE#2373 - nasa/cFE#2466 - nasa/cFE#2468 - nasa/cFE#2470 *PSP* - nasa/PSP#421 *osal* - nasa/osal#1413 Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Isaac Rowe <[email protected]> Co-authored by: Jacob Hageman <[email protected]> Co-authored by: Frank Kühndel <[email protected]>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Dec 5, 2023
*Combines:* to_lab v2.5.0-rc4+dev71 ci_lab v2.5.0-rc4+dev77 cFE v7.0.0-rc4+dev424 PSP v1.6.0-rc4+dev102 osal v6.0.0-rc4+dev243 **Includes:** *to_lab* - nasa/to_lab#173 *ci_lab* - nasa/ci_lab#157 - nasa/ci_lab#159 - nasa/ci_lab#161 *cFE* - nasa/cFE#2409 - nasa/cFE#2373 - nasa/cFE#2466 - nasa/cFE#2468 - nasa/cFE#2470 *PSP* - nasa/PSP#421 *osal* - nasa/osal#1413 Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Isaac Rowe <[email protected]> Co-authored by: Jacob Hageman <[email protected]> Co-authored by: Frank Kühndel <[email protected]>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Dec 5, 2023
*Combines:* to_lab v2.5.0-rc4+dev71 ci_lab v2.5.0-rc4+dev77 cFE v7.0.0-rc4+dev424 PSP v1.6.0-rc4+dev102 osal v6.0.0-rc4+dev243 **Includes:** *to_lab* - nasa/to_lab#173 *ci_lab* - nasa/ci_lab#157 - nasa/ci_lab#159 - nasa/ci_lab#161 *cFE* - nasa/cFE#2409 - nasa/cFE#2373 - nasa/cFE#2466 - nasa/cFE#2468 - nasa/cFE#2470 *PSP* - nasa/PSP#421 *osal* - nasa/osal#1413 Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Isaac Rowe <[email protected]> Co-authored by: Jacob Hageman <[email protected]> Co-authored by: Frank Kühndel <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
A clear and concise description of what the contribution is.
Testing performed
Steps taken to test the contribution:
coverage-vxworks-tasks-testrunner.exe. The test executed successfully (with out crash) when build with-O2as well as-O0. This was RTEMS 6, ARM architecture and BSPxilinx_zynq_a9_qemuand tests run on QEMU.2402f753b6e45341437bb352fad59a97485f27ceand OSAL7e1ffbb61053e1805a0f7dd401b17f9d90e25fbd. These where the standard "ouf-of-box" cFS builds forSIMULATION=native(Linux) and forSIMULATION=i686-rtems6.Expected behavior changes
Test
coverage-vxworks-tasks-testrunner.exeshould not crash.System(s) tested on
See above.
Additional context
None.
Third party code
None.
Contributor Info - All information REQUIRED for consideration of pull request
Frank Kuehndel, embedded brains GmbH & Co. KG