Fix #1107, Remove unreachable branch (superfluous if condition)#1368
Fix #1107, Remove unreachable branch (superfluous if condition)#1368
Conversation
chillfig
added
coverage
unit-test
|
Does this change branch coverage results at all? If so I recommend updating: |
thnkslprpt
force-pushed
the
fix-1107-remove-dead-branch
branch
from
19dc2da to
a357ce4
Compare
thnkslprpt
force-pushed
the
fix-1107-remove-dead-branch
branch
from
a357ce4 to
ea2faf7
Compare
Thanks! I need a checklist or something - that's the second time I forgot to update these parameters for allowed exceptions to coverage. Anyway I updated it now - it had actually become out-of-date at some point before this PR (was allowing 4 exceptions when the main branch was already down to only 3 missed branches). I've lowered it now from 4 to 2. |
jphickey
left a comment
jphickey
left a comment
There was a problem hiding this comment.
If I remember correctly, this could be a remnant from the days when there was a global volume table in OSAL that could pre-init these items. I think we've fully purged that, and I concur I can't see any path though the code where this condition could ever be false.
dmknutsen
added
CCB:Ready
dzbaker
added
CCB:Approved
*Combines:* cFE equuleus-rc1+dev84 osal equuleus-rc1+dev41 **Includes:** *cFE* - nasa/cFE#2505 *osal* - nasa/osal#1368 Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Avi Weiss <[email protected]>
*Combines:* cFE equuleus-rc1+dev84 osal equuleus-rc1+dev41 **Includes:** *cFE* - nasa/cFE#2505 *osal* - nasa/osal#1368 Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Avi Weiss <[email protected]>
7 participants
Checklist
Describe the contribution
OS_FileSys_Initialize#1107ifcondition removed - removing an unreachable branch (condition is alwaystrue) and slightly improving test coverage.Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.
Expected behavior changes
No change to behavior.
Contributor Info
Avi Weiss @thnkslprpt