Fix #1318, adjust timing on condvar tests#1319
Merged
Conversation
The order of task wakeup when using OS_CondVarSignal() with multiple tasks pending may not be guaranteed. This relaxes the test case so that a specific order is not assumed/required. This also adjust certain sleep times to make sure the test waits long enough for the tasks to do the expected work.
dzbaker
approved these changes
Oct 25, 2022
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Oct 26, 2022
*Combines:* cfe v7.0.0-rc4+dev201 osal v6.0.0-rc4+dev147 **Includes:** *cFS* - #594 - #559 *cFE* - nasa/cFE#2184 *osal* - nasa/osal#1319 Co-authored by: Ariel Adams <[email protected]> Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Haven Carlson <[email protected]>
This was referenced Oct 26, 2022
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Oct 26, 2022
*Combines:* cfe v7.0.0-rc4+dev201 osal v6.0.0-rc4+dev147 **Includes:** *cFS* - #594 - #559 *cFE* - nasa/cFE#2184 *osal* - nasa/osal#1319 Co-authored by: Ariel Adams <[email protected]> Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Haven Carlson <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
The order of task wakeup when using OS_CondVarSignal() with multiple tasks pending may not be guaranteed. This relaxes the test case so that a specific order is not assumed/required. This also adjust certain sleep times to make sure the test waits long enough for the tasks to do the expected work.
Fixes #1318
Testing performed
Execute the "condvar" test multiple times
Execute github workflows
Expected behavior changes
Should resolve/avoid intermittent failure due to tasks not running in expected order
System(s) tested on
Ubuntu 22.04
Additional context
As this failure was intermittent, this needs to be watched in the future to confirm there is no more failure
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.