Conversation
dzbaker
changed the title
dzbaker
changed the title
skliper
approved these changes
Jul 5, 2022
dzbaker
added
the
CCB:Ready
Collaborator
Author
|
CCB 7/6/2022: Amend commit message to follow prescribed format |
dzbaker
added
CCB:Approved
…NFIG_MAX_MODULES.
dzbaker
force-pushed
the
fix-1150-osal-loader-ut-hardcoded-modules
branch
from
a69dd76 to
02aa1d2
Compare
skliper
approved these changes
Jul 6, 2022
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Jul 7, 2022
*Combines:* osal v6.0.0-rc4+dev93 ci_lab v2.5.0-rc4+dev22 to_lab v2.5.0-rc4+dev24 sch_lab v2.5.0-rc4+dev31 **Includes:** - nasa/osal#1265, Set OSAL Loader unit test number of modules to OSAL_CONFIG_MAX_MODULES *Update Minimum CMake Version* - nasa/osal#1267, Update minimum required cmake version - nasa/ci_lab#113, update cmake_minimum_required - nasa/sch_lab#117, update cmake_minimum_required Co-authored by: Jacob Hageman <[email protected]> Co-authored by: Ariel Adams <[email protected]> Co-authored by: Joseph Hickey <[email protected]>
This was referenced Jul 7, 2022
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Jul 8, 2022
*Combines:* osal v6.0.0-rc4+dev93 ci_lab v2.5.0-rc4+dev22 to_lab v2.5.0-rc4+dev24 sch_lab v2.5.0-rc4+dev31 **Includes:** - nasa/osal#1265, Set OSAL Loader unit test number of modules to OSAL_CONFIG_MAX_MODULES *Update Minimum CMake Version* - nasa/osal#1267, Update minimum required cmake version - nasa/ci_lab#113, update cmake_minimum_required - nasa/sch_lab#117, update cmake_minimum_required Co-authored by: Jacob Hageman <[email protected]> Co-authored by: Ariel Adams <[email protected]> Co-authored by: Joseph Hickey <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Fixes #1150
Testing performed
Printed value of MOD variable in CMakeLists.txt to ensure that it gets set to one more than the OSAL_CONFIG_MAX_MODULES value
Ran OSAL unit tests
Expected behavior changes
OSAL Loader unit tests will now support up to OSAL_CONFIG_MAX_MODULES modules.
System(s) tested on