os/posix: port of the posix implementation to macOS (take 2)#1161
Closed
os/posix: port of the posix implementation to macOS (take 2)#1161
Conversation
This was referenced Sep 22, 2021
stanislaw
force-pushed
the
2021-09-20-macos-osal-rebase
branch
from
a58e82a to
37aa88c
Compare
stanislaw
force-pushed
the
2021-09-20-macos-osal-rebase
branch
2 times, most recently
from
8bba5a2 to
07c250b
Compare
Contributor
Author
|
Two questions:
Thank you. |
stanislaw
force-pushed
the
2021-09-20-macos-osal-rebase
branch
from
07c250b to
f34de36
Compare
stanislaw
force-pushed
the
2021-09-20-macos-osal-rebase
branch
from
f34de36 to
5d9269f
Compare
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Adds a continuous integration check to ensure new commits adhere to standard format. Some minor format fix
Collaborator
|
CCB 13 October 2022: May be best to close for now and reopen if need arises. Some issues introduced on Linux. @dzbaker will investigate further. |
Collaborator
|
Closing as discussed at CCB. Will reopen if need arises. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
This is an improved version of the previous macOS-related PR: #352. Since 2020, the improvements in the OSAL's build system made it possible to reuse most of the Linux/POSIX layer and reduce the size of the diff to just a few lines plus the addition of several small libraries that are missing on macOS.
Testing performed
Expected behavior changes
With this change, it should be possible to run the cFS OSAL on macOS.
Related nice-to-have and non-blocking issues:
System(s) tested on
Additional context
I am not sure how much the macOS port is relevant to the community. This work still needs discussion (5-10 trivial-to-medium discussion items) and I clearly need someone from the cFS team to support this effort.
Third party code
I have left a comment on the
mqueue.hfile that points to the book where the implementation was adapted from.Contributor Info - All information REQUIRED for consideration of pull request
Stanislav Pankevich, Personal.
The individual CLA has been signed.