Skip to content

Fix #1148, Enable symbol api test and MIR dump too large#1149

Merged
astrogeco merged 2 commits intonasa:integration-candidatefrom
skliper:fix1148-symbol_test
Sep 21, 2021
Merged

Fix #1148, Enable symbol api test and MIR dump too large#1149
astrogeco merged 2 commits intonasa:integration-candidatefrom
skliper:fix1148-symbol_test

Conversation

@skliper
Copy link
Contributor

@skliper skliper commented Sep 15, 2021

Describe the contribution

Always runs symbol tests now and checks for not implemented. Also will report MIR for a symbol table that won't fit instead of causing a failure.

Testing performed
Ran on MCP750, confirmed pass. CI.

Expected behavior changes
Symbol test now isn't skipped

System(s) tested on

  • Hardware: MCP750
  • OS: VxWorks 6.9
  • Versions: Bundle main + this commit

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Sep 15, 2021
@skliper skliper added this to the 6.0.0 milestone Sep 15, 2021
@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Sep 15, 2021
@astrogeco
Copy link
Contributor

CCB:2021-09-15 APPROVED

@skliper
Copy link
Contributor Author

skliper commented Sep 15, 2021

Updated to also handle name to large... I could split if needed but it's basically the same concept (and builds on previous commit)

@astrogeco astrogeco changed the base branch from main to integration-candidate September 21, 2021 01:08
@astrogeco astrogeco merged commit 94e6e35 into nasa:integration-candidate Sep 21, 2021
@skliper skliper deleted the fix1148-symbol_test branch October 22, 2021 19:37
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
…lsrv_guide

Fix nasa#1149, remove cfeesugshellsrv from user guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CCB:Approved Indicates code review and approval by community CCB

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Symbol API test uses old OS_INCLUDE_MODULE_LOADER, ends up skipping tests

3 participants