Fix #1115, Add absolute branch coverage check#1117
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Aug 6, 2021
Merged
Fix #1115, Add absolute branch coverage check#1117astrogeco merged 1 commit intonasa:integration-candidatefrom
astrogeco merged 1 commit intonasa:integration-candidatefrom
Conversation
skliper
suggested changes
Jul 26, 2021
Contributor
skliper
left a comment
skliper
left a comment
There was a problem hiding this comment.
Actually, could you leave in the 100% check for line coverage since it's still a criteria we want to check. Just add the absolute branch coverage check.
nmullane
force-pushed
the
fix1115-branch-coverage
branch
from
f407310 to
e5e7799
Compare
skliper
approved these changes
Jul 27, 2021
nmullane
force-pushed
the
fix1115-branch-coverage
branch
from
38dce85 to
40ecace
Compare
Contributor
Author
|
This added absolute branch coverage check should now be passing in Github Actions since #1114 has now been merged. |
nmullane
force-pushed
the
fix1115-branch-coverage
branch
from
40ecace to
d465000
Compare
astrogeco
reviewed
Aug 3, 2021
astrogeco
added
the
CCB:Ready
Check for absolute number of missed branches in github workflow instead of checking a percentage. Ensure that the number of missed branches does not increase from the current 4 missed branches.
nmullane
force-pushed
the
fix1115-branch-coverage
branch
from
d465000 to
dd1ebcc
Compare
astrogeco
added
CCB:Approved
Contributor
|
CCB:2021-08-04 APPROVED |
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Aug 6, 2021
nasa/osal#1127 osal-IC - nasa/osal#1117, Add absolute branch coverage check
2 tasks
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Aug 11, 2021
**Combines** - nasa/cFE#1772, v6.8.0-rc1+dev844 - nasa/osal#1127, v5.1.0-rc1+dev590 **Includes** *cFE* - nasa/cFE#1737, Move global count into test global struct. - nasa/cFE#1722, Add ES application control API functional tests - nasa/cFE#1743, Update coverage test to use UtAssert macros - nasa/cFE#1734, Add table api functional tests - nasa/cFE#1753, Add Generic Counter API test - nasa/cFE#1766, finish ES misc API functional test - nasa/cFE#1764, last char truncated in coverage log output - nasa/cFE#1728, Mistakes in some copyright headers - nasa/cFE#1767, Add misc time api functional test cFE - nasa/cFE#1749, Add Functional Test for EVS Reset Filters API - nasa/cFE#1781, RTEMS CFE_FT_Global build failure - nasa/cFE#1796, replace VOIDCALL assert macro *osal* - nasa/osal#1117, Add absolute branch coverage check
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Aug 11, 2021
**Combines** - nasa/cFE#1772, v6.8.0-rc1+dev844 - nasa/osal#1127, v5.1.0-rc1+dev590 **Includes** *cFE* - nasa/cFE#1737, Move global count into test global struct. - nasa/cFE#1722, Add ES application control API functional tests - nasa/cFE#1743, Update coverage test to use UtAssert macros - nasa/cFE#1734, Add table api functional tests - nasa/cFE#1753, Add Generic Counter API test - nasa/cFE#1766, finish ES misc API functional test - nasa/cFE#1764, last char truncated in coverage log output - nasa/cFE#1728, Mistakes in some copyright headers - nasa/cFE#1767, Add misc time api functional test cFE - nasa/cFE#1749, Add Functional Test for EVS Reset Filters API - nasa/cFE#1781, RTEMS CFE_FT_Global build failure - nasa/cFE#1796, replace VOIDCALL assert macro *osal* - nasa/osal#1117, Add absolute branch coverage check Co-authored-by: Joseph Hickey <[email protected]> Co-authored-by: Alex Campbell <[email protected]> Co-authored-by: Niall Mullane <[email protected]> Co-authored-by: Paul <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check for absolute number of missed branches in GitHub workflow instead of checking a percentage branch coverage.
Ensure that the number of missed branches does not increase from the current 4 missed branches.
Describe the contribution
Fixes #1115. The PR #1114 that is currently in the integration candidate branch has only 4 missed branches in the unit tests. This PR checks that the number of missed branches is <= 4 instead of checking the percentage branch coverage. This puts an absolute limit on the number of missed branches.
Testing performed
Steps taken to test the contribution:
Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.
System(s) tested on
Contributor Info - All information REQUIRED for consideration of pull request
Niall Mullane - GSFC 582 Intern