osal Integration candidate: 2021-07-13#1100
Merged
Conversation
The underlying OS mechanism that rejects calls to timer APIs from timer callbacks does not work on anything except POSIX. This skips these unit tests on non-POSIX platforms, and also adds documentation clearly indicating that the API must not be called from a timer context.
Per review feedback, removes comment that was stale and no longer valid, and describe why only POSIX_OS is enabled here on this check.
Fix #1083, timer reconfig tests
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jul 13, 2021
**Combines:** nasa/cFE#1661, v6.8.0-rc1+dev746 nasa/osal#1100, v5.1.0-rc1+dev569 *Includes:* nasa/osal#1089, timer reconfig tests nasa/cFE#1656, Size unit test table load buffer based on config nasa/cFE#1657, Add SB Pipe Management Functional Tests
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jul 13, 2021
**Combines:** nasa/cFE#1661, v6.8.0-rc1+dev746 nasa/osal#1100, v5.1.0-rc1+dev569 *Includes:* nasa/osal#1089, timer reconfig tests nasa/cFE#1656, Size unit test table load buffer based on config nasa/cFE#1657, Add SB Pipe Management Functional Tests
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#1100, Update highest MsgId documentation/verification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Part of nasa/cFS#297
Testing
osal Checks https://github.com/nasa/osal/pull/1100/checks
cFS Bundle Checks https://github.com/nasa/cFS/pull/297/checks
Authors
@jphickey
Description
PR #1089,
Fix #1083, timer reconfig tests