Skip to content

Fix #1052, implement missing parameter/retcode test permutations#1066

Merged
astrogeco merged 15 commits intonasa:integration-candidatefrom
jphickey:fix-1052-retcode-permutations
Jun 20, 2021
Merged

Fix #1052, implement missing parameter/retcode test permutations#1066
astrogeco merged 15 commits intonasa:integration-candidatefrom
jphickey:fix-1052-retcode-permutations

Conversation

@jphickey
Copy link
Contributor

@jphickey jphickey commented Jun 3, 2021

Describe the contribution
Another pass through the API to ensure that:

  1. every function parameter marked "nonnull" in doxygen has an individual OS_INVALID_POINTER retcode test
  2. every function parameter marked "nonzero" in doxygen has an individual OS_ERR_INVALID_SIZE retcode test
  3. every function parameter accepting an osal_id_t type has two OS_ERR_INVALID_ID retcode tests, and that it is tested with OS_OBJECT_ID_UNDEFINED and UT_OBJID_INCORRECT (which is not zero, but not valid).

Testing performed
Run all unit tests, and run validation script on tests logs to confirm parameters have been exercised and confirmed for each required retcode.

Expected behavior changes
Missing tests are implemented

System(s) tested on
Ubuntu

Additional context
This PR will have each subsystem done as separate commits

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

@jphickey
Copy link
Contributor Author

jphickey commented Jun 3, 2021

After Binsem fix:

RETCODE: OS_BinSemCreate[NULL@0]=>OS_INVALID_POINTER
 --> validated by coveragetest-binsem.c:64 (02.003)
 --> validated by ut_oscore_binsem_test.c:76 (06.001)
RETCODE: OS_BinSemCreate[NULL@1]=>OS_INVALID_POINTER
 --> validated by coveragetest-binsem.c:65 (02.004)
 --> validated by ut_oscore_binsem_test.c:79 (06.002)
RETCODE: OS_BinSemDelete[OS_OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_binsem_test.c:137 (07.002)
RETCODE: OS_BinSemDelete[UT_OBJID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_binsem_test.c:136 (07.001)
RETCODE: OS_BinSemFlush[OS_OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_binsem_test.c:161 (08.002)
RETCODE: OS_BinSemFlush[UT_OBJID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_binsem_test.c:160 (08.001)
RETCODE: OS_BinSemGetIdByName[NULL@1]=>OS_INVALID_POINTER
 --> validated by coveragetest-binsem.c:160 (08.004)
 --> validated by ut_oscore_binsem_test.c:273 (12.002)
RETCODE: OS_BinSemGetInfo[NULL@1]=>OS_INVALID_POINTER
 --> validated by coveragetest-binsem.c:181 (09.004)
 --> validated by ut_oscore_binsem_test.c:312 (13.003)
RETCODE: OS_BinSemGetInfo[OS_OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_binsem_test.c:307 (13.002)
RETCODE: OS_BinSemGetInfo[UT_OBJID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_binsem_test.c:306 (13.001)
RETCODE: OS_BinSemGive[OS_OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_binsem_test.c:186 (09.002)
RETCODE: OS_BinSemGive[UT_OBJID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_binsem_test.c:185 (09.001)
RETCODE: OS_BinSemTake[OS_OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_binsem_test.c:212 (10.002)
RETCODE: OS_BinSemTake[UT_OBJID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_binsem_test.c:211 (10.001)
RETCODE: OS_BinSemTimedWait[OS_OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_binsem_test.c:237 (11.002)
RETCODE: OS_BinSemTimedWait[UT_OBJID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_binsem_test.c:236 (11.001)

@jphickey
Copy link
Contributor Author

jphickey commented Jun 3, 2021

After CountSem fix:

RETCODE: OS_CountSemCreate[NULL@0]=>OS_INVALID_POINTER
 --> validated by coveragetest-countsem.c:64 (02.003)
 --> validated by ut_oscore_countsem_test.c:78 (14.001)
RETCODE: OS_CountSemCreate[NULL@1]=>OS_INVALID_POINTER
 --> validated by coveragetest-countsem.c:65 (02.004)
 --> validated by ut_oscore_countsem_test.c:83 (14.002)
RETCODE: OS_CountSemDelete[OS_OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_countsem_test.c:166 (15.002)
RETCODE: OS_CountSemDelete[UT_OBJID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_countsem_test.c:165 (15.001)
RETCODE: OS_CountSemGetIdByName[NULL@1]=>OS_INVALID_POINTER
 --> validated by coveragetest-countsem.c:146 (07.004)
 --> validated by ut_oscore_countsem_test.c:305 (19.002)
RETCODE: OS_CountSemGetInfo[NULL@1]=>OS_INVALID_POINTER
 --> validated by coveragetest-countsem.c:167 (08.004)
 --> validated by ut_oscore_countsem_test.c:355 (20.003)
RETCODE: OS_CountSemGetInfo[OS_OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_countsem_test.c:348 (20.002)
RETCODE: OS_CountSemGetInfo[UT_OBJID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_countsem_test.c:347 (20.001)
RETCODE: OS_CountSemGive[OS_OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_countsem_test.c:195 (16.002)
RETCODE: OS_CountSemGive[UT_OBJID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_countsem_test.c:194 (16.001)
RETCODE: OS_CountSemTake[OS_OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_countsem_test.c:226 (17.002)
RETCODE: OS_CountSemTake[UT_OBJID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_countsem_test.c:225 (17.001)
RETCODE: OS_CountSemTimedWait[OS_OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_countsem_test.c:256 (18.002)
RETCODE: OS_CountSemTimedWait[UT_OBJID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_countsem_test.c:255 (18.001)

@jphickey
Copy link
Contributor Author

jphickey commented Jun 3, 2021

After Mutex fix:

RETCODE: OS_MutSemCreate[NULL@0]=>OS_INVALID_POINTER
 --> validated by coveragetest-mutex.c:63 (02.003)
 --> validated by ut_oscore_mutex_test.c:79 (21.001)
RETCODE: OS_MutSemCreate[NULL@1]=>OS_INVALID_POINTER
 --> validated by coveragetest-mutex.c:64 (02.004)
 --> validated by ut_oscore_mutex_test.c:84 (21.002)
RETCODE: OS_MutSemDelete[OS_OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_mutex_test.c:152 (22.002)
RETCODE: OS_MutSemDelete[UT_OBJID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_mutex_test.c:151 (22.001)
RETCODE: OS_MutSemGetIdByName[NULL@1]=>OS_INVALID_POINTER
 --> validated by coveragetest-mutex.c:158 (06.004)
 --> validated by ut_oscore_mutex_test.c:249 (25.002)
RETCODE: OS_MutSemGetInfo[NULL@1]=>OS_INVALID_POINTER
 --> validated by coveragetest-mutex.c:179 (07.004)
 --> validated by ut_oscore_mutex_test.c:297 (26.003)
RETCODE: OS_MutSemGetInfo[OS_OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_mutex_test.c:290 (26.002)
RETCODE: OS_MutSemGetInfo[UT_OBJID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_mutex_test.c:289 (26.001)
RETCODE: OS_MutSemGive[OS_OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_mutex_test.c:180 (23.002)
RETCODE: OS_MutSemGive[UT_OBJID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_mutex_test.c:179 (23.001)
RETCODE: OS_MutSemTake[OS_OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_mutex_test.c:213 (24.002)
RETCODE: OS_MutSemTake[UT_OBJID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_mutex_test.c:212 (24.001)

@jphickey jphickey force-pushed the fix-1052-retcode-permutations branch from 0058ceb to 205cdc3 Compare June 3, 2021 21:57
@jphickey
Copy link
Contributor Author

jphickey commented Jun 3, 2021

After Queue Fix:

RETCODE: OS_QueueCreate[0@3]=>OS_ERR_INVALID_SIZE
 --> validated by ut_oscore_queue_test.c:93 (27.003)
RETCODE: OS_QueueCreate[NULL@0]=>OS_INVALID_POINTER
 --> validated by ut_oscore_queue_test.c:83 (27.001)
RETCODE: OS_QueueCreate[NULL@1]=>OS_INVALID_POINTER
 --> validated by ut_oscore_queue_test.c:88 (27.002)
RETCODE: OS_QueueDelete[OS_OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_queue_test.c:164 (28.002)
RETCODE: OS_QueueDelete[UT_OBJID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_queue_test.c:163 (28.001)
RETCODE: OS_QueueGetIdByName[NULL@1]=>OS_INVALID_POINTER
 --> validated by ut_oscore_queue_test.c:380 (31.002)
RETCODE: OS_QueueGetInfo[NULL@1]=>OS_INVALID_POINTER
 --> validated by ut_oscore_queue_test.c:429 (32.003)
RETCODE: OS_QueueGetInfo[OS_OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_queue_test.c:422 (32.002)
RETCODE: OS_QueueGetInfo[UT_OBJID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_queue_test.c:421 (32.001)
RETCODE: OS_QueueGet[0@2]=>OS_ERR_INVALID_SIZE
 --> validated by coveragetest-queue.c:122 (04.004)
 --> validated by ut_oscore_queue_test.c:211 (30.005)
RETCODE: OS_QueueGet[NULL@1]=>OS_INVALID_POINTER
 --> validated by ut_oscore_queue_test.c:209 (30.003)
RETCODE: OS_QueueGet[NULL@3]=>OS_INVALID_POINTER
 --> validated by ut_oscore_queue_test.c:210 (30.004)
RETCODE: OS_QueueGet[OS_OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_queue_test.c:199 (30.002)
RETCODE: OS_QueueGet[UT_OBJID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_queue_test.c:197 (30.001)
RETCODE: OS_QueuePut[0@2]=>OS_ERR_INVALID_SIZE
 --> validated by coveragetest-queue.c:150 (05.004)
 --> validated by ut_oscore_queue_test.c:321 (29.005)
RETCODE: OS_QueuePut[NULL@1]=>OS_INVALID_POINTER
 --> validated by ut_oscore_queue_test.c:319 (29.003)
RETCODE: OS_QueuePut[OS_OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_queue_test.c:311 (29.002)
RETCODE: OS_QueuePut[UT_OBJID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_queue_test.c:310 (29.001)

@jphickey
Copy link
Contributor Author

jphickey commented Jun 3, 2021

After Task Fix:

RETCODE: OS_TaskCreate[0@4]=>OS_ERR_INVALID_SIZE
 --> validated by ut_oscore_task_test.c:136 (36.004)
RETCODE: OS_TaskCreate[NULL@0]=>OS_INVALID_POINTER
 --> validated by coveragetest-task.c:118 (03.003)
 --> validated by ut_oscore_task_test.c:115 (36.001)
RETCODE: OS_TaskCreate[NULL@1]=>OS_INVALID_POINTER
 --> validated by coveragetest-task.c:121 (03.004)
 --> validated by ut_oscore_task_test.c:122 (36.002)
RETCODE: OS_TaskCreate[NULL@2]=>OS_INVALID_POINTER
 --> validated by coveragetest-task.c:124 (03.005)
 --> validated by ut_oscore_task_test.c:129 (36.003)
RETCODE: OS_TaskDelete[OS_OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_task_test.c:228 (37.002)
RETCODE: OS_TaskDelete[UT_OBJID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_task_test.c:227 (37.001)
RETCODE: OS_TaskFindIdBySystemData[NULL@0]=>OS_INVALID_POINTER
 --> validated by ut_oscore_task_test.c:613 (45.001)
 --> validated by ut_oscore_task_test.c:613 (45.004)
RETCODE: OS_TaskGetIdByName[NULL@1]=>OS_INVALID_POINTER
 --> validated by coveragetest-task.c:228 (09.004)
 --> validated by ut_oscore_task_test.c:517 (43.002)
RETCODE: OS_TaskGetInfo[NULL@1]=>OS_INVALID_POINTER
 --> validated by coveragetest-task.c:257 (10.006)
 --> validated by ut_oscore_task_test.c:571 (44.003)
RETCODE: OS_TaskGetInfo[OS_OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_task_test.c:562 (44.002)
RETCODE: OS_TaskGetInfo[UT_OBJID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_task_test.c:561 (44.001)
RETCODE: OS_TaskSetPriority[OS_OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_task_test.c:435 (41.002)
RETCODE: OS_TaskSetPriority[UT_OBJID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_task_test.c:434 (41.001)

@jphickey jphickey force-pushed the fix-1052-retcode-permutations branch from 8354d06 to ecd298a Compare June 4, 2021 18:44
@jphickey
Copy link
Contributor Author

jphickey commented Jun 4, 2021

After Module fix:

RETCODE: OS_ModuleInfo[NULL@1]=>OS_INVALID_POINTER
 --> validated by ut_osloader_module_test.c:237 (03.003)
RETCODE: OS_ModuleInfo[OBJECT_ID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by ut_osloader_module_test.c:227 (03.001)
RETCODE: OS_ModuleInfo[OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by ut_osloader_module_test.c:228 (03.002)
RETCODE: OS_ModuleLoad[NULL@1]=>OS_INVALID_POINTER
 --> validated by ut_osloader_module_test.c:93 (01.002)
RETCODE: OS_ModuleLoad[NULL@2]=>OS_INVALID_POINTER
 --> validated by ut_osloader_module_test.c:99 (01.003)
RETCODE: OS_ModuleSymbolLookup[NULL@1]=>OS_INVALID_POINTER
 --> validated by ut_osloader_symtable_test.c:145 (04.003)
RETCODE: OS_ModuleSymbolLookup[NULL@2]=>OS_INVALID_POINTER
 --> validated by ut_osloader_symtable_test.c:146 (04.004)
RETCODE: OS_ModuleSymbolLookup[OBJECT_ID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by ut_osloader_symtable_test.c:135 (04.002)
RETCODE: OS_ModuleSymbolLookup[OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by ut_osloader_symtable_test.c:134 (04.001)
RETCODE: OS_ModuleUnload[OBJECT_ID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by ut_osloader_module_test.c:187 (02.001)
RETCODE: OS_ModuleUnload[OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by ut_osloader_module_test.c:188 (02.002)
RETCODE: OS_SymbolLookup[NULL@0]=>OS_INVALID_POINTER
 --> validated by ut_osloader_symtable_test.c:83 (05.001)
RETCODE: OS_SymbolLookup[NULL@1]=>OS_INVALID_POINTER
 --> validated by ut_osloader_symtable_test.c:88 (05.002)
RETCODE: OS_SymbolTableDump[NULL@0]=>OS_INVALID_POINTER
 --> validated by ut_osloader_symtable_test.c:182 (06.001)

@jphickey
Copy link
Contributor Author

jphickey commented Jun 4, 2021

After Network Fix:

RETCODE: OS_NetworkGetHostName[NULL@0]=>OS_INVALID_POINTER
 --> validated by coveragetest-network.c:60 (03.003)
 --> validated by ut_osnetwork_misc_test.c:153 (02.001)
RETCODE: OS_NetworkGetHostName[ZERO@1]=>OS_ERR_INVALID_SIZE
 --> validated by coveragetest-network.c:61 (03.004)
 --> validated by ut_osnetwork_misc_test.c:158 (02.002)

@jphickey
Copy link
Contributor Author

jphickey commented Jun 4, 2021

After Select fix:

RETCODE: OS_SelectFdAdd[NULL@0]=>OS_INVALID_POINTER
 --> validated by ut_oscore_select_test.c:103 (33.003)
RETCODE: OS_SelectFdAdd[OBJECT_ID_INCORRECT@1]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_select_test.c:107 (33.006)
RETCODE: OS_SelectFdAdd[OBJECT_ID_UNDEFINED@1]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_select_test.c:108 (33.007)
RETCODE: OS_SelectFdClear[NULL@0]=>OS_INVALID_POINTER
 --> validated by ut_oscore_select_test.c:104 (33.004)
RETCODE: OS_SelectFdClear[OBJECT_ID_INCORRECT@1]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_select_test.c:109 (33.008)
RETCODE: OS_SelectFdClear[OBJECT_ID_UNDEFINED@1]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_select_test.c:110 (33.009)
RETCODE: OS_SelectFdZero[NULL@0]=>OS_INVALID_POINTER
 --> validated by ut_oscore_select_test.c:102 (33.002)
RETCODE: OS_SelectSingle[NULL@1]=>OS_INVALID_POINTER
 --> validated by coveragetest-select.c:51 (02.002)
 --> validated by ut_oscore_select_test.c:135 (34.001)
RETCODE: OS_SelectSingle[OBJECT_ID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_select_test.c:152 (34.006)
RETCODE: OS_SelectSingle[OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by ut_oscore_select_test.c:153 (34.007)

@jphickey
Copy link
Contributor Author

jphickey commented Jun 4, 2021

After Shell fix:

RETCODE: OS_ShellOutputToFile[NULL@0]=>OS_INVALID_POINTER
 --> validated by ut_osfile_fileio_test.c:1440 (20.003)
RETCODE: OS_ShellOutputToFile[OBJECT_ID_INCORRECT@1]=>OS_ERR_INVALID_ID
 --> validated by ut_osfile_fileio_test.c:1427 (20.001)
RETCODE: OS_ShellOutputToFile[OBJECT_ID_UNDEFINED@1]=>OS_ERR_INVALID_ID
 --> validated by ut_osfile_fileio_test.c:1428 (20.002)

@jphickey
Copy link
Contributor Author

jphickey commented Jun 4, 2021

After Socket fix:

RETCODE: OS_SocketAccept[NULL@1]=>OS_INVALID_POINTER
 --> validated by network-api-test.c:506 (04.008)
RETCODE: OS_SocketAccept[NULL@2]=>OS_INVALID_POINTER
 --> validated by network-api-test.c:507 (04.009)
RETCODE: OS_SocketAccept[OBJECT_ID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by network-api-test.c:504 (04.006)
RETCODE: OS_SocketAccept[OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by network-api-test.c:505 (04.007)
RETCODE: OS_SocketAddrFromString[NULL@0]=>OS_INVALID_POINTER
 --> validated by network-api-test.c:113 (01.011)
RETCODE: OS_SocketAddrFromString[NULL@1]=>OS_INVALID_POINTER
 --> validated by network-api-test.c:114 (01.012)
RETCODE: OS_SocketAddrGetPort[NULL@0]=>OS_INVALID_POINTER
 --> validated by network-api-test.c:106 (01.008)
RETCODE: OS_SocketAddrGetPort[NULL@1]=>OS_INVALID_POINTER
 --> validated by network-api-test.c:107 (01.009)
RETCODE: OS_SocketAddrInit[NULL@0]=>OS_INVALID_POINTER
 --> validated by network-api-test.c:98 (01.004)
RETCODE: OS_SocketAddrSetPort[NULL@0]=>OS_INVALID_POINTER
 --> validated by network-api-test.c:102 (01.006)
RETCODE: OS_SocketAddrToString[NULL@0]=>OS_INVALID_POINTER
 --> validated by network-api-test.c:119 (01.015)
RETCODE: OS_SocketAddrToString[NULL@2]=>OS_INVALID_POINTER
 --> validated by network-api-test.c:120 (01.016)
RETCODE: OS_SocketAddrToString[ZERO@1]=>OS_ERR_INVALID_SIZE
 --> validated by network-api-test.c:118 (01.014)
RETCODE: OS_SocketBind[NULL@1]=>OS_INVALID_POINTER
 --> validated by network-api-test.c:262 (03.019)
RETCODE: OS_SocketBind[OBJECT_ID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by network-api-test.c:259 (03.016)
RETCODE: OS_SocketBind[OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by network-api-test.c:258 (03.015)
RETCODE: OS_SocketConnect[NULL@1]=>OS_INVALID_POINTER
 --> validated by network-api-test.c:613 (04.035)
RETCODE: OS_SocketConnect[OBJECT_ID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by network-api-test.c:610 (04.032)
RETCODE: OS_SocketConnect[OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by network-api-test.c:611 (04.033)
RETCODE: OS_SocketGetIdByName[NULL@0]=>OS_INVALID_POINTER
 --> validated by network-api-test.c:287 (03.034)
RETCODE: OS_SocketGetIdByName[NULL@1]=>OS_INVALID_POINTER
 --> validated by network-api-test.c:288 (03.035)
RETCODE: OS_SocketGetInfo[NULL@1]=>OS_INVALID_POINTER
 --> validated by network-api-test.c:284 (03.033)
RETCODE: OS_SocketGetInfo[OBJECT_ID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by network-api-test.c:283 (03.032)
RETCODE: OS_SocketGetInfo[OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by network-api-test.c:282 (03.031)
RETCODE: OS_SocketOpen[NULL@0]=>OS_INVALID_POINTER
 --> validated by coveragetest-sockets.c:101 (03.003)
 --> validated by network-api-test.c:94 (01.001)
RETCODE: OS_SocketRecvFrom[NULL@1]=>OS_INVALID_POINTER
 --> validated by network-api-test.c:270 (03.023)
RETCODE: OS_SocketRecvFrom[OBJECT_ID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by network-api-test.c:267 (03.021)
RETCODE: OS_SocketRecvFrom[OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by network-api-test.c:265 (03.020)
RETCODE: OS_SocketRecvFrom[ZERO@2]=>OS_ERR_INVALID_SIZE
 --> validated by coveragetest-sockets.c:395 (07.005)
 --> validated by network-api-test.c:271 (03.024)
RETCODE: OS_SocketSendTo[NULL@1]=>OS_INVALID_POINTER
 --> validated by network-api-test.c:277 (03.028)
RETCODE: OS_SocketSendTo[OBJECT_ID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by network-api-test.c:275 (03.026)
RETCODE: OS_SocketSendTo[OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by network-api-test.c:274 (03.025)
RETCODE: OS_SocketSendTo[ZERO@2]=>OS_ERR_INVALID_SIZE
 --> validated by network-api-test.c:278 (03.029)
RETCODE: OS_SocketShutdown[OBJECT_ID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by network-api-test.c:571 (04.019)
RETCODE: OS_SocketShutdown[OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by network-api-test.c:572 (04.020)

@jphickey
Copy link
Contributor Author

jphickey commented Jun 4, 2021

After Timebase fix:

RETCODE: OS_TimeBaseCreate[NULL@0]=>OS_INVALID_POINTER
 --> validated by time-base-api-test.c:84 (01.001)
RETCODE: OS_TimeBaseCreate[NULL@1]=>OS_INVALID_POINTER
 --> validated by time-base-api-test.c:85 (01.002)
RETCODE: OS_TimeBaseDelete[OBJECT_ID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by time-base-api-test.c:155 (01.029)
RETCODE: OS_TimeBaseDelete[OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by time-base-api-test.c:154 (01.028)
RETCODE: OS_TimeBaseGetFreeRun[NULL@1]=>OS_INVALID_POINTER
 --> validated by time-base-api-test.c:228 (01.050)
RETCODE: OS_TimeBaseGetFreeRun[OBJECT_ID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by time-base-api-test.c:227 (01.049)
RETCODE: OS_TimeBaseGetFreeRun[OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by time-base-api-test.c:226 (01.048)
RETCODE: OS_TimeBaseGetIdByName[NULL@0]=>OS_INVALID_POINTER
 --> validated by time-base-api-test.c:176 (01.034)
RETCODE: OS_TimeBaseGetIdByName[NULL@1]=>OS_INVALID_POINTER
 --> validated by time-base-api-test.c:177 (01.035)
RETCODE: OS_TimeBaseGetInfo[NULL@1]=>OS_INVALID_POINTER
 --> validated by time-base-api-test.c:210 (01.045)
RETCODE: OS_TimeBaseGetInfo[OBJECT_ID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by time-base-api-test.c:209 (01.044)
RETCODE: OS_TimeBaseGetInfo[OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by time-base-api-test.c:208 (01.043)
RETCODE: OS_TimeBaseSet[OBJECT_ID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by time-base-api-test.c:140 (01.026)
RETCODE: OS_TimeBaseSet[OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by time-base-api-test.c:139 (01.025)

@jphickey
Copy link
Contributor Author

jphickey commented Jun 4, 2021

After timer fix:

RETCODE: OS_TimerAdd[NULL@0]=>OS_INVALID_POINTER
 --> validated by timer-add-api-test.c:185 (01.050)
RETCODE: OS_TimerAdd[NULL@1]=>OS_INVALID_POINTER
 --> validated by timer-add-api-test.c:190 (01.055)
RETCODE: OS_TimerAdd[NULL@3]=>OS_INVALID_POINTER
 --> validated by timer-add-api-test.c:188 (01.053)
RETCODE: OS_TimerAdd[OBJECT_ID_INCORRECT@2]=>OS_ERR_INVALID_ID
 --> validated by timer-add-api-test.c:187 (01.052)
RETCODE: OS_TimerAdd[OBJECT_ID_UNDEFINED@2]=>OS_ERR_INVALID_ID
 --> validated by timer-add-api-test.c:186 (01.051)
RETCODE: OS_TimerCreate[NULL@0]=>OS_INVALID_POINTER
 --> validated by ut_ostimer_timerio_test.c:182 (01.001)
RETCODE: OS_TimerCreate[NULL@1]=>OS_INVALID_POINTER
 --> validated by ut_ostimer_timerio_test.c:183 (01.002)
RETCODE: OS_TimerCreate[NULL@3]=>OS_INVALID_POINTER
 --> validated by ut_ostimer_timerio_test.c:239 (01.008)
RETCODE: OS_TimerDelete[OBJECT_ID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by ut_ostimer_timerio_test.c:334 (02.001)
RETCODE: OS_TimerDelete[OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by ut_ostimer_timerio_test.c:335 (02.002)
RETCODE: OS_TimerGetIdByName[NULL@0]=>OS_INVALID_POINTER
 --> validated by coveragetest-time.c:285 (06.003)
 --> validated by ut_ostimer_timerio_test.c:524 (03.001)
RETCODE: OS_TimerGetIdByName[NULL@1]=>OS_INVALID_POINTER
 --> validated by ut_ostimer_timerio_test.c:525 (03.002)
RETCODE: OS_TimerGetInfo[NULL@1]=>OS_INVALID_POINTER
 --> validated by ut_ostimer_timerio_test.c:607 (04.003)
RETCODE: OS_TimerGetInfo[OBJECT_ID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by ut_ostimer_timerio_test.c:596 (04.001)
RETCODE: OS_TimerGetInfo[OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by ut_ostimer_timerio_test.c:597 (04.002)
RETCODE: OS_TimerSet[OBJECT_ID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by ut_ostimer_timerio_test.c:412 (05.001)
RETCODE: OS_TimerSet[OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by ut_ostimer_timerio_test.c:413 (05.002)

@jphickey
Copy link
Contributor Author

jphickey commented Jun 4, 2021

After directory fix:

RETCODE: OS_DirectoryClose[OBJECT_ID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by ut_osfile_dirio_test.c:286 (04.001)
RETCODE: OS_DirectoryClose[OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by ut_osfile_dirio_test.c:287 (04.002)
RETCODE: OS_DirectoryOpen[NULL@0]=>OS_INVALID_POINTER
 --> validated by coveragetest-dir.c:77 (03.003)
 --> validated by ut_osfile_dirio_test.c:216 (03.002)
RETCODE: OS_DirectoryOpen[NULL@1]=>OS_INVALID_POINTER
 --> validated by ut_osfile_dirio_test.c:215 (03.001)
RETCODE: OS_DirectoryRead[NULL@1]=>OS_INVALID_POINTER
 --> validated by coveragetest-dir.c:105 (05.002)
 --> validated by ut_osfile_dirio_test.c:383 (05.003)
RETCODE: OS_DirectoryRead[OBJECT_ID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by ut_osfile_dirio_test.c:361 (05.001)
RETCODE: OS_DirectoryRead[OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by ut_osfile_dirio_test.c:362 (05.002)
RETCODE: OS_DirectoryRewind[OBJECT_ID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by ut_osfile_dirio_test.c:453 (06.001)
RETCODE: OS_DirectoryRewind[OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by ut_osfile_dirio_test.c:454 (06.002)
RETCODE: OS_mkdir[NULL@0]=>OS_INVALID_POINTER
 --> validated by ut_osfile_dirio_test.c:134 (02.001)

@jphickey
Copy link
Contributor Author

jphickey commented Jun 4, 2021

After FileSys fix:

RETCODE: OS_FS_GetPhysDriveName[NULL@0]=>OS_INVALID_POINTER
 --> validated by ut_osfilesys_diskio_test.c:601 (06.001)
RETCODE: OS_FS_GetPhysDriveName[NULL@1]=>OS_INVALID_POINTER
 --> validated by ut_osfilesys_diskio_test.c:602 (06.002)
RETCODE: OS_FileSysAddFixedMap[NULL@0]=>OS_INVALID_POINTER
 --> validated by file-sys-add-fixed-map-api-test.c:57 (01.004)
RETCODE: OS_FileSysAddFixedMap[NULL@1]=>OS_INVALID_POINTER
 --> validated by coveragetest-filesys.c:60 (02.003)
 --> validated by file-sys-add-fixed-map-api-test.c:58 (01.005)
RETCODE: OS_FileSysAddFixedMap[NULL@2]=>OS_INVALID_POINTER
 --> validated by coveragetest-filesys.c:59 (02.002)
 --> validated by file-sys-add-fixed-map-api-test.c:59 (01.006)
RETCODE: OS_FileSysStatVolume[NULL@0]=>OS_INVALID_POINTER
 --> validated by ut_osfilesys_diskio_test.c:917 (10.001)
RETCODE: OS_FileSysStatVolume[NULL@1]=>OS_INVALID_POINTER
 --> validated by ut_osfilesys_diskio_test.c:922 (10.002)
RETCODE: OS_GetFsInfo[NULL@0]=>OS_INVALID_POINTER
 --> validated by ut_osfilesys_diskio_test.c:671 (07.001)
RETCODE: OS_TranslatePath[NULL@0]=>OS_INVALID_POINTER
 --> validated by coveragetest-filesys.c:446 (11.004)
 --> validated by ut_osfilesys_diskio_test.c:734 (08.001)
RETCODE: OS_TranslatePath[NULL@1]=>OS_INVALID_POINTER
 --> validated by coveragetest-filesys.c:445 (11.003)
 --> validated by ut_osfilesys_diskio_test.c:735 (08.002)
RETCODE: OS_chkfs[NULL@0]=>OS_INVALID_POINTER
 --> validated by ut_osfilesys_diskio_test.c:827 (09.001)
RETCODE: OS_initfs[NULL@1]=>OS_INVALID_POINTER
 --> validated by ut_osfilesys_diskio_test.c:141 (02.001)
RETCODE: OS_initfs[NULL@2]=>OS_INVALID_POINTER
 --> validated by ut_osfilesys_diskio_test.c:142 (02.002)
RETCODE: OS_mkfs[NULL@1]=>OS_INVALID_POINTER
 --> validated by ut_osfilesys_diskio_test.c:256 (01.001)
RETCODE: OS_mkfs[NULL@2]=>OS_INVALID_POINTER
 --> validated by ut_osfilesys_diskio_test.c:257 (01.002)
RETCODE: OS_mount[NULL@0]=>OS_INVALID_POINTER
 --> validated by ut_osfilesys_diskio_test.c:427 (04.001)
RETCODE: OS_mount[NULL@1]=>OS_INVALID_POINTER
 --> validated by ut_osfilesys_diskio_test.c:428 (04.002)
RETCODE: OS_rmfs[NULL@0]=>OS_INVALID_POINTER
 --> validated by ut_osfilesys_diskio_test.c:351 (03.001)
RETCODE: OS_unmount[NULL@0]=>OS_INVALID_POINTER
 --> validated by ut_osfilesys_diskio_test.c:512 (05.001)

@jphickey
Copy link
Contributor Author

jphickey commented Jun 4, 2021

After File fix:

RETCODE: OS_CloseFileByName[NULL@0]=>OS_INVALID_POINTER
 --> validated by ut_osfile_fileio_test.c:1733 (24.001)
RETCODE: OS_FDGetInfo[NULL@1]=>OS_INVALID_POINTER
 --> validated by ut_osfile_fileio_test.c:1532 (21.001)
RETCODE: OS_FDGetInfo[OBJECT_ID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by ut_osfile_fileio_test.c:1541 (21.002)
RETCODE: OS_FDGetInfo[OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by ut_osfile_fileio_test.c:1542 (21.003)
RETCODE: OS_FileOpenCheck[NULL@0]=>OS_INVALID_POINTER
 --> validated by ut_osfile_fileio_test.c:1597 (22.001)
RETCODE: OS_OpenCreate[NULL@0]=>OS_INVALID_POINTER
 --> validated by ut_osfile_fileio_test.c:178 (08.001)
 --> validated by ut_osfile_fileio_test.c:316 (09.002)
RETCODE: OS_OpenCreate[NULL@1]=>OS_INVALID_POINTER
 --> validated by ut_osfile_fileio_test.c:180 (08.002)
 --> validated by ut_osfile_fileio_test.c:315 (09.001)
RETCODE: OS_TimedRead[NULL@1]=>OS_INVALID_POINTER
 --> validated by coveragetest-file.c:116 (04.003)
 --> validated by network-api-test.c:601 (04.027)
RETCODE: OS_TimedRead[OBJECT_ID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by network-api-test.c:597 (04.025)
RETCODE: OS_TimedRead[OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by network-api-test.c:599 (04.026)
RETCODE: OS_TimedRead[ZERO@2]=>OS_ERR_INVALID_SIZE
 --> validated by coveragetest-file.c:117 (04.004)
 --> validated by network-api-test.c:602 (04.028)
RETCODE: OS_TimedWrite[NULL@1]=>OS_INVALID_POINTER
 --> validated by coveragetest-file.c:137 (05.003)
 --> validated by network-api-test.c:610 (04.032)
RETCODE: OS_TimedWrite[OBJECT_ID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by network-api-test.c:606 (04.030)
RETCODE: OS_TimedWrite[OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by network-api-test.c:608 (04.031)
RETCODE: OS_TimedWrite[ZERO@2]=>OS_ERR_INVALID_SIZE
 --> validated by coveragetest-file.c:138 (05.004)
 --> validated by network-api-test.c:611 (04.033)
RETCODE: OS_chmod[NULL@0]=>OS_INVALID_POINTER
 --> validated by ut_osfile_fileio_test.c:804 (14.001)
RETCODE: OS_close[OBJECT_ID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by ut_osfile_fileio_test.c:457 (10.001)
RETCODE: OS_close[OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by ut_osfile_fileio_test.c:458 (10.002)
RETCODE: OS_cp[NULL@0]=>OS_INVALID_POINTER
 --> validated by ut_osfile_fileio_test.c:1202 (18.001)
RETCODE: OS_cp[NULL@1]=>OS_INVALID_POINTER
 --> validated by ut_osfile_fileio_test.c:1203 (18.002)
RETCODE: OS_lseek[OBJECT_ID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by ut_osfile_fileio_test.c:749 (13.001)
RETCODE: OS_lseek[OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by ut_osfile_fileio_test.c:750 (13.002)
RETCODE: OS_mv[NULL@0]=>OS_INVALID_POINTER
 --> validated by ut_osfile_fileio_test.c:1326 (19.001)
RETCODE: OS_mv[NULL@1]=>OS_INVALID_POINTER
 --> validated by ut_osfile_fileio_test.c:1327 (19.002)
RETCODE: OS_read[NULL@1]=>OS_INVALID_POINTER
 --> validated by ut_osfile_fileio_test.c:542 (11.001)
RETCODE: OS_read[OBJECT_ID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by ut_osfile_fileio_test.c:552 (11.003)
RETCODE: OS_read[OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by ut_osfile_fileio_test.c:553 (11.004)
RETCODE: OS_read[ZERO@2]=>OS_ERR_INVALID_SIZE
 --> validated by ut_osfile_fileio_test.c:543 (11.002)
RETCODE: OS_remove[NULL@0]=>OS_INVALID_POINTER
 --> validated by ut_osfile_fileio_test.c:988 (16.001)
RETCODE: OS_rename[NULL@0]=>OS_INVALID_POINTER
 --> validated by ut_osfile_fileio_test.c:1090 (17.001)
RETCODE: OS_rename[NULL@1]=>OS_INVALID_POINTER
 --> validated by ut_osfile_fileio_test.c:1091 (17.002)
RETCODE: OS_stat[NULL@0]=>OS_INVALID_POINTER
 --> validated by ut_osfile_fileio_test.c:888 (15.001)
RETCODE: OS_stat[NULL@1]=>OS_INVALID_POINTER
 --> validated by ut_osfile_fileio_test.c:889 (15.002)
RETCODE: OS_write[NULL@1]=>OS_INVALID_POINTER
 --> validated by ut_osfile_fileio_test.c:650 (12.001)
RETCODE: OS_write[OBJECT_ID_INCORRECT@0]=>OS_ERR_INVALID_ID
 --> validated by ut_osfile_fileio_test.c:661 (12.003)
RETCODE: OS_write[OBJECT_ID_UNDEFINED@0]=>OS_ERR_INVALID_ID
 --> validated by ut_osfile_fileio_test.c:662 (12.004)
RETCODE: OS_write[ZERO@2]=>OS_ERR_INVALID_SIZE
 --> validated by ut_osfile_fileio_test.c:651 (12.002)

@jphickey
Copy link
Contributor Author

jphickey commented Jun 4, 2021

This appears to be the last one! That should cover all APIs.

Note that the timer tests also assume/require that #1065 gets merged first. It moves some asserts back into timer callbacks, instead of saving the RC and asserting later (simpler and more reliable that way).

@jphickey jphickey force-pushed the fix-1052-retcode-permutations branch from 1e232ed to b1139bd Compare June 8, 2021 18:29
@jphickey jphickey added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Jun 9, 2021
@jphickey
Copy link
Contributor Author

jphickey commented Jun 9, 2021

This is complete now but it still needs a rebase to (depends on some items from the 2021-06-08 review set).

@astrogeco astrogeco linked an issue Jun 9, 2021 that may be closed by this pull request
Ensure all unit test cases for invalid ID use UNDEFINED plus another value #1052
Closed
@astrogeco
Copy link
Contributor

astrogeco commented Jun 9, 2021 •
edited
Loading

CCB:2021-06-09 APPROVED

  • rebase and try to merge asap
  • can we share the script? maybe on the fork, would be a good intern task

@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Jun 16, 2021
@jphickey jphickey force-pushed the fix-1052-retcode-permutations branch from b1139bd to d35de1b Compare June 17, 2021 15:48
@jphickey jphickey marked this pull request as ready for review June 17, 2021 15:49
@jphickey
Copy link
Contributor Author

jphickey commented Jun 17, 2021

Rebased to latest baseline, should be mergable now.

@jphickey jphickey force-pushed the fix-1052-retcode-permutations branch from d35de1b to 46eaa70 Compare June 17, 2021 15:57
@astrogeco astrogeco changed the base branch from main to integration-candidate June 20, 2021 22:42
@astrogeco astrogeco merged commit a8ae7c4 into nasa:integration-candidate Jun 20, 2021
@astrogeco astrogeco mentioned this pull request Jun 21, 2021
Merged
astrogeco added a commit to nasa/cFS that referenced this pull request Jun 21, 2021
@astrogeco
IC:2021-06-22, Add osal PR
6815a23 
nasa/osal#1066, implement missing parameter/retcode test permutations
@astrogeco astrogeco mentioned this pull request Jun 21, 2021
Merged
@astrogeco
Copy link
Contributor

astrogeco commented Jun 23, 2021

CCB:2021-06-23 APPROVED

astrogeco added a commit to nasa/cFS that referenced this pull request Jun 24, 2021
@astrogeco
IC:2021-06-22, cfe, osal, and coding standard
0d2cd48 
*Combines*

- nasa/elf2cfetbl#81
- nasa/tblCRCTool#52
- nasa/ci_lab#88
- nasa/sch_lab#83
- nasa/sample_app#150
- nasa/sample_lib#64
- nasa/to_lab#100

*Includes*

- nasa/cFE#1630, correct path to users guide warning log
- nasa/cFE#1621, add additional test cases for Child Tasks
- nasa/cFE#1608, Add cfe functional tests to CI
- nasa/cFE#1627, rename/clean CFE coverage assert macros
- nasa/cFE#1623, Added UT tests for cFE ES Api
- nasa/cFE#1634, Expand CDS Functional Tests.
- nasa/cFE#1633, add test log file
- nasa/cFE#1594, Event ID updates
- nasa/cFE#1624, scrub all UT_Report calls

- nasa/osal#1066, implement missing parameter/retcode test permutations

- nasa/cFS-GroundSystem#182, Add test start command script for cmdUtil
- nasa/tblCRCTool#51, add printf conversion casts

** Implement Coding Standard in CodeQL **

- nasa/cFS-GroundSystem#180
- nasa/elf2cfetbl#80
- nasa/tblCRCTool#49

- nasa/ci_lab#87
- nasa/sch_lab#79
- nasa/sample_app#149
- nasa/sample_lib#63
- nasa/to_lab#99
astrogeco added a commit to nasa/cFS that referenced this pull request Jun 24, 2021
@astrogeco @skliper
@jphickey @ArielSAdamsNASA @zanzaben @pepepr08
IC:2021-06-22, cfe, osal, and coding standard
1afe0e9 
*Combines*

- nasa/cFE#1632, v6.8.0-rc1+dev726
- nasa/osal#1079, v5.1.0-rc1+dev548

- nasa/ci_lab#88, v2.4.0-rc1+dev42
- nasa/sch_lab#83, v2.4.0-rc1+dev40
- nasa/sample_app#150, v1.2.0-rc1+dev66
- nasa/sample_lib#64, v1.2.0-rc1+dev38
- nasa/to_lab#100, v2.4.0-rc1+dev49

- nasa/elf2cfetbl#81, v3.2.0-rc1+dev30
- nasa/tblCRCTool#52, v1.2.0-rc1+dev33
- nasa/cFS-GroundSystem#183, v2.2.0-rc1+dev52

*Includes*

- nasa/cFE#1630, correct path to users guide warning log
- nasa/cFE#1621, add additional test cases for Child Tasks
- nasa/cFE#1608, Add cfe functional tests to CI
- nasa/cFE#1627, rename/clean CFE coverage assert macros
- nasa/cFE#1623, Added UT tests for cFE ES Api
- nasa/cFE#1634, Expand CDS Functional Tests.
- nasa/cFE#1633, add test log file
- nasa/cFE#1594, Event ID updates
- nasa/cFE#1624, scrub all UT_Report calls

- nasa/osal#1066, implement missing parameter/retcode test permutations

- nasa/cFS-GroundSystem#182, Add test start command script for cmdUtil
- nasa/tblCRCTool#51, add printf conversion casts

** Implement Coding Standard in CodeQL **

- nasa/cFS-GroundSystem#180
- nasa/elf2cfetbl#80
- nasa/tblCRCTool#49

- nasa/ci_lab#87
- nasa/sch_lab#79
- nasa/sample_app#149
- nasa/sample_lib#63
- nasa/to_lab#99

Co-authored-by: Jacob Hageman <[email protected]>
Co-authored-by: Joseph Hickey <[email protected]>
Co-authored-by: Ariel Adams <[email protected]>
Co-authored-by: Alex Campbell <[email protected]>
Co-authored-by: Jose F Martinez Pedraza <[email protected]>
@jphickey jphickey deleted the fix-1052-retcode-permutations branch August 3, 2021 15:19
@skliper skliper added this to the 6.0.0 milestone Sep 24, 2021
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
@astrogeco
Merge pull request nasa#1066 from nasa/integration-candidate
1ede295 
cFE Integration Candidate: 2021-01-05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CCB:Approved Indicates code review and approval by community CCB

Projects

None yet

Milestone

Caelum

Development

Successfully merging this pull request may close these issues.

Ensure all unit test cases for invalid ID use UNDEFINED plus another value

3 participants

@jphickey @astrogeco @skliper