Fix #48, string table identification.#49
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Jul 8, 2020
Merged
Fix #48, string table identification.#49astrogeco merged 1 commit intonasa:integration-candidatefrom
astrogeco merged 1 commit intonasa:integration-candidatefrom
Conversation
Support ELF files that have all strings, including ELF section names, in one single ".strtab" section in the ELF file. This gives preferential treatment to a section named ".strtab" as this should always be the section which contains the names for the ".symtab" section. This should also be true of ELF files that contain other strtab sections, such as a ".dynstr" section.
Contributor
Author
|
Note, this also adds a warning/error exit condition if no usable string table is identified. In the previous code, it would proceed using offset 0 (the init value of Additionally, if the tool failed to identify the |
skliper
approved these changes
Jul 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Support ELF files that have all strings, including ELF section names, in one single ".strtab" section in the ELF file.
This gives preferential treatment to a section named ".strtab" as this should always be the section which contains the names for the ".symtab" section.
This should also be true of ELF files that contain other strtab sections, such as a ".dynstr" section.
Fixes #48
Testing performed
Confirmed that normal table files built using GCC (e.g. those in the sample framework configuration) are identical, before and after this change is applied.
Confirmed that this is now able to also correctly parse an ELF file from
clangwhich has all strings in a single.strtabsection.Expected behavior changes
Now correctly parses ELF files that do not have a separate
.shstrtaband.strtabsection.System(s) tested on
Ubuntu 20.04
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.