Merged
Conversation
Fix #45 - null terminates src/dst filenames
Support ELF files that have all strings, including ELF section names, in one single ".strtab" section in the ELF file. This gives preferential treatment to a section named ".strtab" as this should always be the section which contains the names for the ".symtab" section. This should also be true of ELF files that contain other strtab sections, such as a ".dynstr" section.
Fix #48, string table identification.
Create version file and macros to match implementation in other cFS repositories
Reformat string output for "elf2cfetbl -V" Add string helper macro Add macros for buildnumber, elf2cfetbl version, and version string Set buildnumber
Resolve #50, Add baseline and build number to version.h
astrogeco
force-pushed
the
integration-candidate
branch
from
a9c8334 to
96dca59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #45
Fix #48
Resolve #6
Resolve #50
Testing performed
Bundle CI - https://github.com/nasa/cFS/pull/108/checks
Expected behavior changes
PR #46 - Adds a null to the end of SrcFilename and DstFilename when using strncpy.
PR #49 - Support ELF files that have all strings, including ELF section names, in one single ".strtab" section in the ELF file.
PR #51 - Version reporting now uses the version numbers defined in
elf_version.hand reports build number.System(s) tested on
Ubuntu - CI
Additional context
Part of nasa/cFS#108
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Christopher D. Knight, NASA-ARC
Joseph Hickey, Vantage Systems, Inc.
Gerardo E. Cruz-Ortiz, NASA-GSFC