Conversation
Remove the now-unnecessary inclusion of CFE TBL internal definitions. All logic in this tool is based on public include files only. CFE ensures that the header sizes are always a multiple of 4 bytes, so the logic to selectively byte-align is unnecessary. CFE now requires this to be 4-byte aligned. Clean up all hacks in the CMake recipe, the build is now much more straightforward when internal headers aren't being used.
jphickey
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Integration candidate for pull requests approved at 2019-10-09 CCB
Covers the following pull requests:
#15 - Add guide on creating table files
#20 - add validation for rtncode and update bracket to standard
#21 - init DstFile and SrcFile to NULL, Validate DstFile and SrcFile
#23 - use path_max instead of os_max_file_name
#24 - Clean up elf2cfetbl build logic
Testing performed
Build code for native host (SIMULATION=native) with unit test enabled
Execute CFE core, issued various test commands from cmdUtil
Execute all unit tests and confirm passage.
Expected behavior changes
None
System(s) tested on:
Ubuntu 18.04.2 LTS 64-bit
Additional context
NA
Contributor Info
Joseph Hickey, Vantage Systems, Inc.