Fix #46 Recommended lgtm python issues#96
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Jul 1, 2020
Merged
Fix #46 Recommended lgtm python issues#96astrogeco merged 1 commit intonasa:integration-candidatefrom
astrogeco merged 1 commit intonasa:integration-candidatefrom
Conversation
|
This pull request fixes 3 alerts when merging 257f929 into 5c14375 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 3 alerts when merging 257f929 into b7b7ad1 - view on LGTM.com fixed alerts:
|
Contributor
|
@lbleier-GSFC is this ready? |
Contributor
Author
If lgtm runs without issue, then yes :) |
astrogeco
added
conflict
CCB:Ready
Contributor
Can you rebase and see if these conflicts get resolved? |
Problems shown in this issue were fixed in nasa#72 as part of updates/refactoring. Other lgtm issues addressed here. Problems in auto-generated .py files not addressed. Auto-generated .py files renamed with Ui_ prefix. The lgtm.yml file must be updated to exclude these See nasa/cFS#92
lbleier-GSFC
force-pushed
the
fix46lgtmissues
branch
from
257f929 to
f52c69d
Compare
Contributor
|
I'm going to need an explanation of what this is supposed to implement... if LGTM is ignoring these files from the cFS yml script I'm not sure what this is supposed to do. |
astrogeco
added
CCB-20200624
and removed
CCB:Ready
Contributor
|
CCB-20200624: Will investigate further at the bundle level to see if files are ignored by lgtm. |
astrogeco
added
CCB:Approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
updates/refactoring.
.pyfiles not addressed..pyfiles renamed withUi_prefix.The
lgtm.ymlfile must be updated to exclude theseSee Update lgtm.yml to exclude Ui files cFS#92
Testing performed
Steps taken to test the contribution:
Pending; need to do lgtm run
Expected behavior changes
No lgtm issues reported in Python code
Contributor Info - All information REQUIRED for consideration of pull request
Leor Bleier, NASA GSFC\Code 582