Skip to content

Integration Candidate: 2020-05-13#90

Merged
astrogeco merged 3 commits intomasterfrom
integration-candidate
May 22, 2020
Merged

Integration Candidate: 2020-05-13#90
astrogeco merged 3 commits intomasterfrom
integration-candidate

Conversation

@astrogeco
Copy link
Contributor

@astrogeco astrogeco commented May 20, 2020 •
edited
Loading

Describe the contribution
Fix #72

Testing performed
Bundle CI - https://travis-ci.com/github/nasa/cFS/builds/167639047

Expected behavior changes
PR #85 - This is a major change, upgrading PyQt4 to PyQt5 and includes a lot of cleanup/refactoring, and changes to the GUI itself

System(s) tested on
Bundle CI - Ubuntu:Bionic

Additional context
Part of nasa/cFS#87

Contributor Info - All information REQUIRED for consideration of pull request
Leor Bleier, NASA-GSFC

lbleier-GSFC and others added 2 commits May 20, 2020 09:15
@lbleier-GSFC
Fix #72 - Upgrade PyQt4 to PyQt5
5ae4d32 
Also includes general fixes/refactoring/cleanup. Also fixes #71
@astrogeco
Merge pull request #85 from lbleier-GSFC/fix72-upgradepyqt
8cb6a28 
Fix #72 and #71, Upgrades to PyQt 5 and sequence count fix
@astrogeco astrogeco mentioned this pull request May 20, 2020
Merged
@lgtm-com
Copy link

lgtm-com bot commented May 22, 2020

This pull request introduces 5 alerts and fixes 35 when merging 8cb6a28 into 1c31f94 - view on LGTM.com

new alerts:

  • 4 for Unused import
  • 1 for Unused local variable

fixed alerts:

  • 25 for Unused import
  • 5 for Unused local variable
  • 2 for First parameter of a method is not named 'self'
  • 1 for Unnecessary pass
  • 1 for Except block handles 'BaseException'
  • 1 for Binding a socket to all network interfaces

@astrogeco astrogeco marked this pull request as ready for review May 22, 2020 14:49
@astrogeco astrogeco merged commit 5c14375 into master May 22, 2020
@lgtm-com
Copy link

lgtm-com bot commented May 22, 2020

This pull request introduces 5 alerts and fixes 35 when merging 31b433c into 1c31f94 - view on LGTM.com

new alerts:

  • 4 for Unused import
  • 1 for Unused local variable

fixed alerts:

  • 25 for Unused import
  • 5 for Unused local variable
  • 2 for First parameter of a method is not named 'self'
  • 1 for Unnecessary pass
  • 1 for Except block handles 'BaseException'
  • 1 for Binding a socket to all network interfaces

@skliper skliper added this to the 2.2.0 milestone Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Bootes

Development

Successfully merging this pull request may close these issues.

Update PyQt4 to PyQt5

3 participants

@astrogeco @skliper @lbleier-GSFC