Skip to content

Fix typos#78

Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom
pgrimaud:master
May 8, 2020
Merged

Fix typos#78
astrogeco merged 1 commit intonasa:integration-candidatefrom
pgrimaud:master

Conversation

@pgrimaud
Copy link
Contributor

@pgrimaud pgrimaud commented Apr 27, 2020

Hello,

This PR will fix :

  • 1 typo in RoutingService.py
  • 2 typos in Subsystems/cmdGui/CHeaderParser.py
  • 1 typo in Subsystems/cmdGui/CommandSystem.py
  • 1 typo in Subsystems/cmdGui/Parameter.py
  • 1 typo in Subsystems/tlmGUI/GenericTelemetry.py
  • 1 typo in Subsystems/tlmGUI/TelemetrySystem.py

Bye! 🤖

@skliper
Copy link
Contributor

skliper commented Apr 27, 2020

Thanks! Preference is to use the pull request template. Have you submitted a CLA (needed to accept an external contribution, just hand sign and email)?

See: https://github.com/nasa/cFE/blob/master/docs/GSC_18128_Corp_CLA_form_1219.pdf or https://github.com/nasa/cFE/blob/master/docs/GSC_18128_Ind_CLA_form_1219.pdf

@skliper skliper added enhancement New feature or request pending CLA CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Apr 27, 2020
@pgrimaud
Copy link
Contributor Author

pgrimaud commented Apr 27, 2020

Should I send CLA to [email protected]?

@skliper
Copy link
Contributor

skliper commented Apr 27, 2020

@pgrimaud Please do!

@pgrimaud
Copy link
Contributor Author

pgrimaud commented Apr 27, 2020

Email sent 👌

@skliper
Copy link
Contributor

skliper commented Apr 29, 2020

Confirmed CLA receipt

@astrogeco
Copy link
Contributor

astrogeco commented Apr 29, 2020

CCB 2020-04-29 : APPROVED

@astrogeco astrogeco added CCB-20200429 CCB:Approved Indicates approval by CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels May 5, 2020
@astrogeco astrogeco changed the base branch from master to integration-candidate May 8, 2020 19:21
@astrogeco astrogeco merged commit 043a33d into nasa:integration-candidate May 8, 2020
@astrogeco astrogeco mentioned this pull request May 13, 2020
Merged
@skliper skliper added this to the 2.2.0 milestone Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@skliper skliper skliper approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CCB:Approved Indicates approval by CCB enhancement New feature or request

Projects

None yet

Milestone

Bootes

Development

Successfully merging this pull request may close these issues.

3 participants

@pgrimaud @skliper @astrogeco