Fix #187, Converted most variable names and function/method names into snake_case#191
Conversation
Some have to be not in python conventions because they override some methods from other depencies where they use C naming conventions for example.
|
This pull request introduces 4 alerts and fixes 4 when merging 73ca0b2 into 12e26ce - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request introduces 4 alerts and fixes 4 when merging f5035f9 into 8651e2e - view on LGTM.com new alerts:
fixed alerts:
|
astrogeco
added
the
CCB:Ready
astrogeco
changed the title
Contributor
|
CCB:2021-08-11 Test thoroughly first, defer to cFS-Draco
|
astrogeco
added
CCB:Approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
A clear and concise description of what the contribution is.
Testing performed
Expected behavior changes
System(s) tested on
Additional context
What is NASA's opinion on this,
what do you think about switching the project to snake_case (python naming convention)?
Contributor Info - All information REQUIRED for consideration of pull request
Paul Oberosler, Individual