Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #93
Fix #128
Testing performed
Bundle CI - https://github.com/nasa/cFS/pull/136/checks
Expected behavior changes
PR #130 - Replaces old code that caused a cast-align warning when strict. Refactored and removed unnecessary code while also following recommended model for
getaddrinfo. Removed old windows support/defines/etc (likely not tested for years, no longer supported).PR #129 - Reduce the size of the
strncpyso that it ensures there's a null byte at the end of the string buffer.System(s) tested on
Ubuntu - CI
Additional context
nasa/cFS#136
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman, NASA-GSFC
Chris Knight, NASA-ARC