Conversation
Problems shown in this issue were fixed in #72 as part of updates/refactoring. Other lgtm issues addressed here. Problems in auto-generated .py files not addressed. Auto-generated .py files renamed with Ui_ prefix. The lgtm.yml file must be updated to exclude these See nasa/cFS#92
Fix #46 Recommended lgtm python issues
|
This pull request introduces 2 alerts when merging 658df9f into defa816 - view on LGTM.com new alerts:
|
Updates GUI and backend to allow user to select header version offsets, or custom byte offsets Also removed the shareddata.py file; no longer needed at this time
astrogeco
force-pushed
the
integration-candidate
branch
from
658df9f to
6fb6e96
Compare
|
This pull request introduces 2 alerts when merging 6fb6e96 into defa816 - view on LGTM.com new alerts:
|
Create version file Import version variables into GroundSystem.py and print in main function Add cmake temporary files to gitignore Fix gitignore problem with CmdUtil directory
|
I ran into a weird error ('CommandSystem' object has no attribute 'tblCmdSys') after I launch the Ground System and try to click the Start Command System button. This error supposedly originates from cFS-GroundSystem/Subsystems/cmdGui/CommandSystem.py, tbl = Command.tblCmdSys. A screenshot for more details (this screenshot is of a newer integration-candidate branch but the error is the same, the line number will just be different, traced back to pr #96): @lbleier-GSFC do you know what's causing this error? |
Seems to be a mismatch between what the backend code is expecting the GUI to have and what the GUI actually has. This error means the backend code is trying to reference a table widget that does not exist (but is supposed to). Need to make sure all the |
Noticed an issue on my end. I will recompile all the .ui files and push |
Issue with GUI, recompiled all .ui files
|
This pull request introduces 2 alerts when merging 08bcfb6 into defa816 - view on LGTM.com new alerts:
|
Resolve #112, add build number and baseline
|
This pull request introduces 2 alerts when merging d29b8fb into defa816 - view on LGTM.com new alerts:
|
astrogeco
force-pushed
the
integration-candidate
branch
from
e1ed96d to
c22f00e
Compare
|
This pull request introduces 2 alerts when merging c22f00e into defa816 - view on LGTM.com new alerts:
|
4 participants
Describe the contribution
Fix #46
Resolve #103
Resolve #112
Testing performed
Bundle CI - https://github.com/nasa/cFS/pull/108/checks
Expected behavior changes
PR #96 - Fixes more lgtm warnings
PR #108 - Allows users to change the byte offsets for sending commands and parsing telemetry, to support different header versions or other implementations of cFS
PR #113 - Adds a file to store version information and reports version upon ground-system startup.
PR #114 - Fixes mismatch between GUI and backend leading to AttributeError bug (Added in 08bcfb6)
System(s) tested on
Ubuntu CI
Additional context
Part of nasa/cFS#108
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Leor Bleir, NASA-GSFC
Gerardo E. Cruz-Ortiz, NASA-GSFC