Resolves #103 Custom header mechanism#108
Resolves #103 Custom header mechanism#108astrogeco merged 3 commits intonasa:integration-candidatefrom
Conversation
|
This PR has commits that are already in master. Can it be cleaned up such that we can review the actual change being proposed here? |
8d3f8be to
1a3b6dc
Compare
|
This pull request introduces 2 alerts when merging 1a3b6dc into 63b672a - view on LGTM.com new alerts:
|
|
This pull request introduces 2 alerts when merging 20fce30 into 63b672a - view on LGTM.com new alerts:
|
c2bd8f2 to
449511e
Compare
|
This pull request introduces 2 alerts when merging 449511e into 63b672a - view on LGTM.com new alerts:
|
|
This pull request introduces 2 alerts when merging e37501f into 63b672a - view on LGTM.com new alerts:
|
I think it's addressed now. Which commits did you notice were "duplicates"? |
|
This pull request introduces 2 alerts when merging e37501f into defa816 - view on LGTM.com new alerts:
|
|
I did do some cleanup, but found a few last-minute issues that I pushed. I can squash those further if necessary |
|
CCB 2020-07-01: APPROVED Replace "enhancement" with a valid linking word: Linking a pull request to an issue Open issue for cross-platform Open issue for ZMQ idea |
|
@lbleier-GSFC if you still have time, can you take a look at the conflicts? If not, maybe @dmknutsen or @JandlynBentley-at-NASA can try |
Updates GUI and backend to allow user to select header version offsets, or custom byte offsets
Updates GUI and backend to allow user to select header version offsets, or custom byte offsets
Also removed the shareddata.py file; no longer needed at this time
e37501f to
fb58248
Compare
|
This pull request introduces 2 alerts when merging fb58248 into aa15da9 - view on LGTM.com new alerts:
|
Should be good now |
Describe the contribution
Fixes #103, implemented the ability to allow users to select the header version byte offset, or custom offsets. In order to support this, some relatively major changes had to be implemented:
cmdUtilto send UDP data. The GroundSystem app in its current form is no longer dependent on the external CcmdUtilapp (also fixes cFS ground system GUI Python code should generate cmd UDP directly #61, at least partially)mmapmodule to share data between processesTesting performed
Steps taken to test the contribution:
Expected behavior changes
The update allows users to change the byte offsets for sending commands and parsing telemetry, to support different header versions or other implementations of cFS
Additional context
cmdUtilis only a subset ofcmdUtil's full functionality. Should the GroundSystem app be updated in the future, the fullcmdUtilmight need to be used again, or the "mini"cmdUtilupdated accordinglyContributor Info - All information REQUIRED for consideration of pull request
Leor Bleier, NASA GSFC\Code 582