Fix #98, Refactor individual UI elements to tables#100
Merged
astrogeco merged 1 commit intonasa:integration-candidatefrom Jun 23, 2020
Merged
Conversation
|
This pull request fixes 3 alerts when merging ab60754 into d298b9c - view on LGTM.com fixed alerts:
|
|
This pull request fixes 3 alerts when merging db0a550 into d298b9c - view on LGTM.com fixed alerts:
|
skliper
changed the title
Contributor
|
@lbleier-GSFC is this ready? |
Contributor
Author
Yes |
astrogeco
added
the
CCB:Ready
Contributor
|
Commit history isn't review friendly... I suggest cleaning up so it's easier to tell what changes you are requesting. |
lbleier-GSFC
force-pushed
the
feature98-refactortotables
branch
from
db0a550 to
b054958
Compare
|
This pull request fixes 3 alerts when merging b054958 into 78c5766 - view on LGTM.com fixed alerts:
|
lbleier-GSFC
force-pushed
the
feature98-refactortotables
branch
3 times, most recently
from
c64b413 to
1eb8a5c
Compare
|
This pull request fixes 3 alerts when merging 1eb8a5c into 78c5766 - view on LGTM.com fixed alerts:
|
Contributor
|
CCB 2020-06-17: APPROVED |
dmknutsen
approved these changes
Jun 17, 2020
astrogeco
added
IC-20200617
CCB:Approved
lbleier-GSFC
force-pushed
the
feature98-refactortotables
branch
from
1eb8a5c to
a68dcda
Compare
Backend updated accordingly. Other various tweaks/fixes as needed
lbleier-GSFC
force-pushed
the
feature98-refactortotables
branch
from
a68dcda to
b8b70ab
Compare
|
This pull request fixes 3 alerts when merging b8b70ab into 78c5766 - view on LGTM.com fixed alerts:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Implements feature #98. Change all individual UI elements to table widgets. Update backend code accordingly
Testing performed
Steps taken to test the contribution:
Expected behavior changes
None, should still work as before with new table widgets
Contributor Info - All information REQUIRED for consideration of pull request
Leor Bleier, NASA GSFC\Code 582