Skip to content

Fix #84, Add GIT SHA#85

Merged
astrogeco merged 3 commits intonasa:integration-candidatefrom
CDKnightNASA:fix-84-git_sha
May 20, 2020
Merged

Fix #84, Add GIT SHA#85
astrogeco merged 3 commits intonasa:integration-candidatefrom
CDKnightNASA:fix-84-git_sha

Conversation

@CDKnightNASA
Copy link
Contributor

@CDKnightNASA CDKnightNASA commented May 14, 2020

Describe the contribution
Adds GIT SHA's to Travis log.

Testing performed
Checked the travis log for this branch.

Contributor Info - All information REQUIRED for consideration of pull request
[email protected]

astrogeco and others added 3 commits May 5, 2020 13:56
@astrogeco
Merge pull request nasa#78 from nasa/integration-candidate
8f8ec69 
Integration Candidate: Fast Track
@astrogeco
Merge pull request nasa#83 from nasa/integration-candidate
a4345d8 
Integration Candidate COMBINED 2020-04-29 and 2020-05-06
@CDKnightNASA
fix nasa#84 - add GIT SHA
c0cc41d
@CDKnightNASA CDKnightNASA linked an issue May 14, 2020 that may be closed by this pull request
report submodule SHA in travis job log #84
Closed
skliper
skliper approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@skliper skliper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend fast-track.

@CDKnightNASA CDKnightNASA added CCB:FastTrack CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels May 14, 2020
@CDKnightNASA CDKnightNASA self-assigned this May 14, 2020
@CDKnightNASA
Copy link
Contributor Author

CDKnightNASA commented May 14, 2020

git sha

@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB IC-20200513 labels May 19, 2020
@astrogeco astrogeco changed the base branch from master to integration-candidate May 19, 2020 20:10
@astrogeco astrogeco added CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) CCB:Approved Indicates code review and approval by community CCB labels May 19, 2020
@astrogeco astrogeco changed the title fix #84 - add GIT SHA Fix #84, Add GIT SHA May 19, 2020
@astrogeco
Copy link
Contributor

astrogeco commented May 20, 2020

CCB 20200520 - APPROVED

@astrogeco astrogeco merged commit 0a580b4 into nasa:integration-candidate May 20, 2020
@astrogeco astrogeco added the CCB:Approved Indicates code review and approval by community CCB label May 20, 2020
@astrogeco astrogeco mentioned this pull request May 22, 2020
Merged
@astrogeco astrogeco added CCB-20200520 and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels May 26, 2020
@skliper skliper added this to the 6.8.0 milestone Jun 1, 2020
chillfig pushed a commit to chillfig/cFS that referenced this pull request Mar 17, 2022
@astrogeco
Merge pull request nasa#85 from jphickey/fix-55-uninit-ptr-warning
e8562bf 
Fix nasa#55, resolve uninitialized pointer warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@skliper skliper skliper approved these changes

@astrogeco astrogeco astrogeco approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@CDKnightNASA CDKnightNASA

Labels

CCB:Approved Indicates code review and approval by community CCB CCB:FastTrack enhancement

Projects

None yet

Milestone

Bootes

Development

Successfully merging this pull request may close these issues.

report submodule SHA in travis job log

3 participants

@CDKnightNASA @astrogeco @skliper