Skip to content

Comments

Fix #742, Adds node20 compatible github actions#751

Merged
dzbaker merged 1 commit intonasa:mainfrom
chillfig:node20
May 21, 2024
Merged

Fix #742, Adds node20 compatible github actions#751
dzbaker merged 1 commit intonasa:mainfrom
chillfig:node20

Conversation

@chillfig
Copy link
Contributor

@chillfig chillfig commented Mar 21, 2024

Checklist (Please check before submitting)

Describe the contribution

Testing performed
chillfig@007d6ea
Tested on fork from link above using rtems containers using Ubuntu 20.04 instead of Ubuntu 18.04.

Expected behavior changes
Suppresses cFS github warnings associated with deprecated node 16 versioned actions.

System(s) tested on

  • OS: Ubuntu 20.04

Additional context
core-flight-system/containers#14 must be considered for merging before this pull request is merged. The cFS rtems github workflows must have respective Ubuntu 20.04 supported rtems container images. If this is merged without containers getting updated, cFS workflows will fail.

Code contributions
N/A

Contributor Info - All information REQUIRED for consideration of pull request
Justin Figueroa, Vantage Systems

@chillfig chillfig added CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) continuous-integration labels Mar 21, 2024
@chillfig chillfig self-assigned this Mar 21, 2024
@chillfig chillfig force-pushed the node20 branch 3 times, most recently from e776c60 to 9703f9b Compare March 27, 2024 13:31
@chillfig chillfig removed the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Mar 28, 2024
@chillfig chillfig added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Apr 18, 2024
@dzbaker dzbaker added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Apr 18, 2024
dzbaker added a commit that referenced this pull request May 6, 2024
*Combines:*

cFE equuleus-rc1+dev141
osal equuleus-rc1+dev66
PSP equuleus-rc1+dev42

**Includes:**

*cFS*
- #751
- #762

*cFE*
- nasa/cFE#2537
- nasa/cFE#2381
- nasa/cFE#2551

*osal*
- nasa/osal#1460

*PSP*
- nasa/PSP#430

Co-authored by: Justin Figueroa <[email protected]>
Co-authored by: Joseph Hickey <[email protected]>
@dzbaker dzbaker mentioned this pull request May 6, 2024
2 tasks
dzbaker added a commit that referenced this pull request May 21, 2024
*Combines:*

cFE equuleus-rc1+dev137
osal equuleus-rc1+dev66
PSP equuleus-rc1+dev42
to_lab equuleus-rc1+dev56

**Includes:**

*cFS*
- #751
- #762

*cFE*
- nasa/cFE#2537
- nasa/cFE#2525

*osal*
- nasa/osal#1460

*PSP*
- nasa/PSP#430

*to_lab*
- nasa/to_lab#198

Co-authored by: Justin Figueroa <[email protected]>
Co-authored by: Joseph Hickey <[email protected]>
Co-authored by: Cody Martin <[email protected]>
dzbaker added a commit that referenced this pull request May 21, 2024
*Combines:*

cFE equuleus-rc1+dev137
osal equuleus-rc1+dev66
PSP equuleus-rc1+dev42
to_lab equuleus-rc1+dev56

**Includes:**

*cFS*
- #751
- #762

*cFE*
- nasa/cFE#2537
- nasa/cFE#2525

*osal*
- nasa/osal#1460

*PSP*
- nasa/PSP#430

*to_lab*
- nasa/to_lab#198

Co-authored by: Justin Figueroa <[email protected]>
Co-authored by: Joseph Hickey <[email protected]>
Co-authored by: Cody Martin <[email protected]>
Co-authored by: Dan Knutsen <[email protected]>
@dzbaker dzbaker merged commit 119cfd4 into nasa:main May 21, 2024
Copy link

@Mattral Mattral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really thoughtful contribution. Thank you.

@dzbaker dzbaker added this to the v7.0.0 milestone Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CCB:Approved Indicates code review and approval by community CCB continuous-integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shared workflow scripts need updates for node.js version

3 participants