Update CI for deploy docs, warnings, and simplify#61
Merged
astrogeco merged 2 commits intonasa:integration-candidatefrom Apr 1, 2020
Merged
Update CI for deploy docs, warnings, and simplify#61astrogeco merged 2 commits intonasa:integration-candidatefrom
astrogeco merged 2 commits intonasa:integration-candidatefrom
Conversation
Integration Candidate 2020-03-18
Contributor
Author
|
@astrogeco @jphickey could you review and merge this? All just CI/README changes, and once this is in I can update the README to reference the deployment documentation (adds the cFE and OSAL user's guide auto-generated pdfs). NOTE - I did only test it in my fork w/ special settings to make it work. There is a chance it may fail the CI check on merge to master by another user, but I'll work with whoever does it to solve it ASAP. Likely failure case could be the GITHUB_TOKEN, but documentation says collaborators should have access to mine. |
jphickey
approved these changes
Mar 28, 2020
Contributor
jphickey
left a comment
jphickey
left a comment
There was a problem hiding this comment.
Generally seems OK. One minor comment/question noted in the docs build.
astrogeco
approved these changes
Apr 1, 2020
This was referenced Apr 1, 2020
chillfig
pushed a commit
to chillfig/cFS
that referenced
this pull request
Mar 17, 2022
Removes the "optimization" for big endian, unlikely to be useful.
chillfig
pushed a commit
to chillfig/cFS
that referenced
this pull request
Mar 17, 2022
Fix nasa#61, remove dependence on ENDIAN macro for checksum
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #28, Deploy documentation
Fix #60, config warnings except for the new ones
introduced by using the latest deployment version
Fix #47, removes permissive mode hack and updates README.md
Adds enforce of no doxygen warnings for osal and users guide
Testing performed
Steps taken to test the contribution:
Expected behavior changes
Old CI script warnings resolved (2 remain based on using development version)
Now enforces no doxygen warnings for user guides
Will deploy documentation to gh_pages branch on push to master
System(s) tested on
Additional context
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC