Fix #607, rework static-analysis workflow#608
Merged
Conversation
jphickey
force-pushed
the
fix-607-static-analysis
branch
2 times, most recently
from
22c73ce to
6ade2f9
Compare
jphickey
added
the
CCB:Ready
ArielSAdamsNASA
approved these changes
Nov 3, 2022
Updates the static analysis workflow: - Make it work with the latest Ubuntu and Cppcheck - Allow callers to pass in a project configuration to get "real" macro definitions and include paths - Streamlined - only generate XML outputs, then use XSLT to convert that to text, rather than running the tool twice. - Streamlined - merge the two XML outputs into one, before converting to sarif and uploading - Streamlined - Call the sarif conversion tool directly, rather than going through a 3rd party action.
jphickey
force-pushed
the
fix-607-static-analysis
branch
from
6ade2f9 to
c36aa2c
Compare
dzbaker
added
CCB:Approved
Contributor
Author
|
As mentioned in the CCB - this also is (partially) related to #488 in that it is changing the cppcheck workflow at the bundle level to be manual dispatch. After going through how cppcheck operates, I can confirm there is really no value-add from running it at both the bundle and submodule levels, it will report the same info in both places. In other modes of operation, there could be a difference, but not in the way it was invoked in this workflow. In the future, if this changes and it is warranted to do so, the static analysis could be set back to push/pull again, but with the current configuration it doesn't (and will not) show anything different. |
dzbaker
added a commit
that referenced
this pull request
Nov 14, 2022
*Combines:* cfe v7.0.0-rc4+dev205 osal v6.0.0-rc4+dev151 cFS-GroundSystem v3.0.0-rc4+dev39 **Includes:** *cFS* - #608 *cFE* - nasa/cFE#2197 *osal* - nasa/osal#1323 *cFS-GroundSystem* - nasa/cFS-GroundSystem#217 - nasa/cFS-GroundSystem#230 Co-authored by: Joseph Hickey <[email protected]> Co-authored-by: Avi Weiss <[email protected]> Co-authored-by: Paul Ober <[email protected]>
dzbaker
added a commit
that referenced
this pull request
Nov 14, 2022
*Combines:* cfe v7.0.0-rc4+dev205 osal v6.0.0-rc4+dev151 cFS-GroundSystem v3.0.0-rc4+dev39 **Includes:** *cFS* - #608 *cFE* - nasa/cFE#2197 *osal* - nasa/osal#1323 *cFS-GroundSystem* - nasa/cFS-GroundSystem#217 - nasa/cFS-GroundSystem#230 Co-authored by: Joseph Hickey <[email protected]> Co-authored-by: Avi Weiss <[email protected]> Co-authored-by: Paul Ober <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Updates the static analysis workflow:
Fixes #607
Testing performed
Update OSAL static analysis to point to this updated reusable workflow instead of the current one (nasa/cFS main) and check results.
Expected behavior changes
More complete/thorough results, while being a simpler workflow overall
System(s) tested on
Github workflow runner (Ubuntu image)
Additional context
This uses the updated baseline, and the cppcheck tool reports more errors than the old version did. So repos that referred to this workflow in the past may have new errors now.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.