Fix #554, Updated ubuntu version in CI workflows#559
Conversation
|
Could also use "ubuntu-latest" so we don't have to update the workflows every time a new version comes out. |
skliper
left a comment
skliper
left a comment
There was a problem hiding this comment.
Looks good to me, I actually prefer explicit 22.04 for elements that are most likely to be impacted by updates so we have better control over when the update happens (vs a surprise when GitHub updates their ubuntu-latest). Is there a matching set of updates in the submodules for any changes needed to pass that should be marked as dependencies? I suspect there's at least minor format updates?
havencarlson
added
the
CCB:Ready
dzbaker
added
CCB:Ignore
havencarlson
force-pushed
the
workflow-ubuntu-update
branch
3 times, most recently
from
0f73291 to
95d9303
Compare
havencarlson
force-pushed
the
workflow-ubuntu-update
branch
2 times, most recently
from
42a5fde to
7d97ef0
Compare
skliper
left a comment
skliper
left a comment
There was a problem hiding this comment.
Note Ubuntu 20.04 default (if you just install clang-format) is version 10.0.0, which is the same as clang-format-10. If you go to 12, you'll need to update all the impacted repos to avoid CI failures from the switch. Seems like it's easier to just stick w/ 10 for Ubuntu 20.04?
|
I think the cppcheck workflow failed for at least osal with Ubuntu 20.04, but should probably check them all. |
havencarlson
force-pushed
the
workflow-ubuntu-update
branch
from
7d97ef0 to
7be4a44
Compare
havencarlson
force-pushed
the
workflow-ubuntu-update
branch
from
7be4a44 to
c66839c
Compare
havencarlson
added
CCB:Ready
*Combines:* cfe v7.0.0-rc4+dev201 osal v6.0.0-rc4+dev147 **Includes:** *cFS* - #594 - #559 *cFE* - nasa/cFE#2184 *osal* - nasa/osal#1319 Co-authored by: Ariel Adams <[email protected]> Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Haven Carlson <[email protected]>
*Combines:* cfe v7.0.0-rc4+dev201 osal v6.0.0-rc4+dev147 **Includes:** *cFS* - #594 - #559 *cFE* - nasa/cFE#2184 *osal* - nasa/osal#1319 Co-authored by: Ariel Adams <[email protected]> Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Haven Carlson <[email protected]>
dzbaker
added
CCB:Approved
4 participants
Checklist (Please check before submitting)
Describe the contribution
Fix #554, update OS versions in github workflows
Testing performed
Check workflow results after pushing
Expected behavior changes
no impact to behavior
System(s) tested on
Browser
Contributor Info - All information REQUIRED for consideration of pull request
Haven Carlson - NASA